Stdlib: sort() for packed string and integer arrays (#209)#225
Merged
Conversation
VM sorts homogeneous list arrays in place for route tables and admin lists. LLVM __hashtable__sortPacked supports dynamic hashtables in JIT/AOT; fixed native literal arrays remain VM-only until native codegen is completed. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sort()for homogeneous packed list arrays (strings and integers) in the VM, matching the acceptance criteria from Stdlib: usort, uasort, and sort() for array ordering in routers #209.HashTable::replacePackedValues()and LLVM__hashtable__sortPackedfor dynamic hashtable arrays in JIT/AOT.array('b','a','c')) sort in VM only for now; JIT/AOT throws a clear error until native-array codegen is completed.Test plan
php vendor/bin/phpunit test/unit/VM/HashTableSortTest.phpphp vendor/bin/phpunit test/compliance/VMTest.php(includessort.phpt)Closes #209
Made with Cursor