JIT/AOT: boxed != / !== and VM loose equality (extends #211)#223
Merged
Conversation
Wire NotEqual/NotIdentical through the compiler and VM, extend JIT lowering for boxed and native operands, and prefer the host C compiler when building the AOT runtime so Docker CI can link web binaries. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve conflicts with upstream #211 work, add VM loose equality for mixed-type !=, and fix compliance expectations (no user-function return types in PHPT). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #219 / #90 with additional work for static compilation and web guards:
__value__vs__value__strict/loose compare viastrcmpand type tags (string route guards).!==for null/bool/native mixes; hostgccpreferred for AOT runtime.ccompile.==/!=for mixed null/bool/int/string operands.Test plan
bash script/docker-ci.sh— 227 VM/compliance tests passCloses #211
Made with Cursor