Repository navigation
Return no siblings for nodes without a parent - #622
Open
nk-batman21 wants to merge 1 commit into
Open
nk-batman21 wants to merge 1 commit into
nk-batman21 wants to merge 1 commit into
Conversation
Siblings, SiblingsFiltered and SiblingsMatcher panicked with a nil pointer dereference when the selection contained a node without a parent, such as the document root or a removed or cloned node. Return no siblings for such nodes, as Next, Prev, NextAll and PrevAll already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Siblings,SiblingsFilteredandSiblingsMatcherpanic with a nil pointer dereference when the selection contains a node without a parent. This happens when some nodes of a selection are removed and the selection is used again, and when calling them ondoc.Selectionor on aClone()d selection.getSiblingNodespassesn.ParenttogetChildrenWithSiblingType, which readsparent.FirstChildin the siblings case.Next,Prev,NextAllandPrevAllalready return nothing for these nodes, and jQuery'ssiblings()returns an empty set for an element without a parent. This change skips nodes without a parent, soitems.Siblings()above returns b and c, anddoc.Siblings()returns an empty selection.Ran:
go test ./... -v -cover(the newTestSiblingsWithoutParentpanics without the change and passes with it)Ran:
go vet ./...,gofmt -l