Skip to content

Parse the WrapAllHtml wrapper in the parent's context #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abo3losh1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Parse the WrapAllHtml wrapper in the parent's context #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4eff09
Parse the WrapAllHtml wrapper in the parent's context
abo3losh1 Oct 14, 2026
9f4d952
Test WrapAllHtml on a raw text element and on text nodes
abo3losh1 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions manipulation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,8 +449,10 @@ func (s *Selection) WrapAllHtml(htmlStr string) *Selection {
var context *html.Node
var nodes []*html.Node
if len(s.Nodes) > 0 {
context = s.Nodes[0]
if context.Parent != nil {
// The wrapper takes the place of the first node, so parse it in the
// context of that node's parent, as WrapHtml does.
context = s.Nodes[0].Parent
if context != nil && context.Type == html.ElementNode {
nodes = parseHtmlWithContext(htmlStr, context, s.parseOpts())
} else {
nodes = parseHtml(htmlStr, s.parseOpts())
Expand Down
16 changes: 16 additions & 0 deletions manipulation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,22 @@ func TestWrapAllHtml(t *testing.T) {
printSel(t, doc.Selection)
}

func TestWrapAllHtmlRawTextElement(t *testing.T) {
// The wrapper must be parsed in the parent's context. Parsed inside a
// textarea it would become text, and the textarea would be lost.
doc := loadString(t, `<html><body><textarea>hi</textarea></body></html>`)
doc.Find("textarea").WrapAllHtml(`<div class="wrap"></div>`)
assertLength(t, doc.Find("body > div.wrap > textarea").Nodes, 1)
printSel(t, doc.Selection)
}

func TestWrapAllHtmlTextNode(t *testing.T) {
doc := loadString(t, `<html><body><p>a <b>b</b></p></body></html>`)
doc.Find("p").Contents().WrapAllHtml(`<span class="wrap"></span>`)
assertLength(t, doc.Find("p > span.wrap > b").Nodes, 1)
printSel(t, doc.Selection)
}

func TestWrapInnerNoContent(t *testing.T) {
doc := Doc2Clone()
doc.Find(".one").WrapInner(".two")
Expand Down