Skip to content

Fix CI #86

Merged
dannielsantiago merged 11 commits intoPtyLab:mainfrom
ShantanuKodgirwar:fix-CI
Apr 10, 2026
Merged

Fix CI #86
dannielsantiago merged 11 commits intoPtyLab:mainfrom
ShantanuKodgirwar:fix-CI

Conversation

@ShantanuKodgirwar
Copy link
Copy Markdown
Contributor

@roflmaostc Made some more changes to make this testing friendly with CI. Also did some dry runs to make sure this works properly. Some of the specifics:

  • Some CI infra changes such as installation issues, updated to the latest version of uv in test.yml, added a workflow_dispatch trigger for manual (dry-)runs, and expanded testing coverage to 3.11–3.13.
  • An additional test added that generates a minimal simu.hdf5 file so few other tests can run without a full dataset present in the repo.
  • Also took care of few warning messages which weren't so important
  • The test badge has a correct URL (it didn't earlier)

@roflmaostc
Copy link
Copy Markdown
Member

CI seems to pass but not testing anything.

So infrastructure works but it's not calling the test, is it?

@ShantanuKodgirwar
Copy link
Copy Markdown
Contributor Author

ShantanuKodgirwar commented Apr 8, 2026

That's not true. Click on the three dots ... and under view details > check "Run tests". There are however some tests that I have flagged to skip, these need some work and come from some legacy implementations.

@roflmaostc
Copy link
Copy Markdown
Member

roflmaostc commented Apr 8, 2026

Ah lol. How small is the dataset that it takes only a few seconds?

13 passed, 20 skipped in 6.09s

Also the skipped tests are normal? -> ok you answered

@ShantanuKodgirwar
Copy link
Copy Markdown
Contributor Author

As of now most of them are small sanity (smoke?) tests mainly taken from whatever was scattered at the package level from the developers + pytest around it. However, there are few reconstruction tests under tests/Engines, but not extensive to cover all use cases. This is some work and I'll need to do that separately. There are a lot of implementations that must be looked at closely for that as well.

@dannielsantiago dannielsantiago merged commit b002f3d into PtyLab:main Apr 10, 2026
3 checks passed
@ShantanuKodgirwar ShantanuKodgirwar deleted the fix-CI branch April 10, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants