Repository navigation
feat(sysgraph): add SysGraph typed envelope (kr0ki roadmap box 2) - #27
Merged
Merged
Conversation
Adds the box-2 typed graph container kr0ki's docs/TODO.md has called for since the semantic-graph layer (iso_ir -> ontology -> sysml_model) landed: a SysGraph snapshot of UFO-stereotyped OntologicalNodes plus the existing ontology::OntologicalEdges between them, ready for a box-3 pattern recognizer to produce and a viewpoint-lowering pass to consume. Follows DESIGN-NOTE-typed-model-layer.md #2.6 (a typed envelope is fine at this layer; serde JSON, round-trip tested) and #2.8 (no SchemaVersion field). Includes a dangling_edges() caller-invoked integrity check since nodes/edges may be pushed by independent passes with no enforced ordering. 5 new tests, cargo fmt clean, clippy -D warnings clean, full suite (244 tests) still green. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/TODO.mdbox 2 from thePromptExecution/kr0kifive-box pipeline: "Graph container type — a typed envelope holding UFO-stereotyped nodes +Vec<OntologicalEdge>."sysgraphmodule:OntologicalNode(id +UfoStereotype+ optional label) andSysGraph(Vec<OntologicalNode>+Vec<ontology::OntologicalEdge>), pluspush_node/push_edge/node()lookup and adangling_edges()caller-invoked integrity check (no referential integrity enforced at construction, since a producer may build nodes/edges in either order or from independent passes).kr0ki'sDESIGN-NOTE-typed-model-layer.md§2.6 (a typed envelope is acceptable at this layer, serde JSON, round-trip tested — same bar assysthread-core'sPositionedGraph) and §2.8 (noSchemaVersionfield).This unblocks kr0ki box 3 (the Kubernetes recognizer) and box 1 (the Rust-source front-end), both of which need a graph container to emit
OntologicalEdges into.Test plan
cargo fmt --checkcleancargo clippy --lib -- -D warningscleanpipeline_*additions onmain) is left to the maintainer