Repository navigation
fix(coherence): reject NaN/infinite inputs in validate_numeric_agreement (closes #15) - #25
Merged
Merged
Conversation
f64::min/f64::max silently drop NaN operands, so [100.0, NaN] folded to spread 0 → Satisfied, and all-NaN input folded to spread -inf ≤ any tolerance → Satisfied. Both are false negatives in a trust-checking primitive — the worst failure mode. Now: non-finite tolerance (NaN, ±inf) or tolerance < 0 → Violated; any non-finite input value → Violated. Regression tests cover mixed NaN, all-NaN, infinite input, and negative/NaN/infinite tolerance. Closes #15
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15.
validate_numeric_agreementfolded its input withf64::min/f64::max, which per IEEE-754 silently drop NaN operands:[100.0, NaN]→ min=100, max=100, spread=0 → Satisfied[NaN, NaN]→ spread=-inf ≤ any tolerance → Satisfied (total garbage reporting perfect agreement)For a coherence/trust-checking primitive this is the worst failure mode — a false negative on undefined input.
Fix
Explicit guards before the fold:
tolerance→ViolatedViolatedRegression tests (4 new, all pass locally — 9/9 in the module)
nan_mixed_with_values_is_violated_not_satisfiedall_nan_input_is_violated_not_satisfiedinfinite_value_is_violatednegative_or_nan_tolerance_is_violatedCloses #15