Repository navigation
Align deployment health checks and configuration with production HTTPS - #52
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Direct deployments to HTTP-only installations probe the wrong port and roll back healthy releases.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Aligns deployment checks with the production HTTPS setup by probing PLDB directly behind Nginx.
Changes:
- Defaults health checks to port 3000 with an environment override.
- Guards bootstrap execution on HTTPS servers and adds an HTTP-only wrapper fallback.
- Updates the root base URL, deployment documentation, and health-check test mock.
| File | Description |
|---|---|
| setup-pldb.sh | Adds HTTPS guard and HTTP-only fallback. |
| settings.scroll | Changes the root base URL to HTTPS. |
| readme.md | Documents production HTTPS and deployment behavior. |
| code/test_deploy_release.py | Requires port 3000 in mocked health checks. |
| code/deploy-release.sh | Adds a configurable health-check endpoint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| flock -w 600 9 | ||
|
|
||
| INSTALL_DIR=/root/pldb | ||
| HEALTH_URL=${PLDB_HEALTH_URL:-http://127.0.0.1:3000/} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.