Repository navigation
test(e2e): wait for the welcome tour to settle before clicking it - #94
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe first-run end-to-end test now waits for the welcome-tour tooltip to settle below the current-debate card before starting a debate or skipping the tour. The wait checks both elements’ bounding boxes and times out after 15 seconds. ChangesFirst-run welcome tour
Estimated code review effort: 2 (Simple) | ~10 minutes Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
#95 carried this PR's commit |
On a slow CI runner the mobile first-run spec clicked the tour's Start debate button just before the tooltip slid below the Current Debate card. The dialog never opened and the motion fill timed out. Both first-run tests now wait for the tooltip's final position, below the card, before they click it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
7c73df7 to
5b40cef
Compare
|
Rebased onto |
Why
The
database-testsjob failed on this PR, but not in a database test. One Playwright test inside./.superset/db-gate.shfailed,first-run.spec.ts › [en] a fresh account starts its first debate from the touron mobile-chromium. The other 70 tests passed.The trace shows the welcome tooltip first rendered on top of the Current Debate card. The test clicked its Start debate button there. A moment later the tooltip slid down to its final spot below the card. The motion dialog never opened, and the Motion fill timed out after 10 s.
What changed
Both first-run tests now wait until the tooltip sits below the card before they click it (
welcomeTourSettled). The app code is unchanged, and the test adds no retries or forced clicks.This PR's original commit, which answers the motion dialog in model-matrix and the canary, reached
mainthrough #95 as9a2a520. I rebased the branch ontomain, so it now holds only this fix.Verification
GitHub refuses to start Actions jobs right now because of account billing, so CI has not run on this head. Local results at this head:
./.superset/db-gate.sh: pgTAP passed, and Playwright had 71 passed and 1 skipped, the same skip as CI.npm run lint,npm run typecheckandnpm run docs:checkpass.I couldn't reproduce the lost click on the VPS. The old spec passed 50 of 50 runs at full speed and 30 of 30 with the CPU slowed 6x. In 35 probe runs that clicked the tooltip before it settled, the dialog still opened. The fix removes the state the CI trace shows, but it doesn't explain why that click was lost. A local pass is not a CI pass.
🤖 Generated with Claude Code
Summary by CodeRabbit