Skip to content

test(e2e): wait for the welcome tour to settle before clicking it - #94

Merged
Programcode merged 1 commit into
mainfrom
fix/e2e-motion-dialog
Oct 7, 2026
Merged

Programcode merged 1 commit into
mainfrom
fix/e2e-motion-dialog

Conversation

@Programcode

@Programcode Programcode commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner

Why

The database-tests job failed on this PR, but not in a database test. One Playwright test inside ./.superset/db-gate.sh failed, first-run.spec.ts › [en] a fresh account starts its first debate from the tour on mobile-chromium. The other 70 tests passed.

The trace shows the welcome tooltip first rendered on top of the Current Debate card. The test clicked its Start debate button there. A moment later the tooltip slid down to its final spot below the card. The motion dialog never opened, and the Motion fill timed out after 10 s.

What changed

Both first-run tests now wait until the tooltip sits below the card before they click it (welcomeTourSettled). The app code is unchanged, and the test adds no retries or forced clicks.

This PR's original commit, which answers the motion dialog in model-matrix and the canary, reached main through #95 as 9a2a520. I rebased the branch onto main, so it now holds only this fix.

Verification

GitHub refuses to start Actions jobs right now because of account billing, so CI has not run on this head. Local results at this head:

  • Full ./.superset/db-gate.sh: pgTAP passed, and Playwright had 71 passed and 1 skipped, the same skip as CI.
  • Before the rebase, the fixed spec ran 5 times on both projects and both locales, and 40 of 40 passed.
  • npm run lint, npm run typecheck and npm run docs:check pass.

I couldn't reproduce the lost click on the VPS. The old spec passed 50 of 50 runs at full speed and 30 of 30 with the CPU slowed 6x. In 35 probe runs that clicked the tooltip before it settled, the dialog still opened. The fix removes the state the CI trace shows, but it doesn't explain why that click was lost. A local pass is not a CI pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Improved first-run tour checks by waiting for the welcome tooltip to settle into position before continuing.

Copilot AI balanced review requested due to automatic review settings October 2, 2026 18:06
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
debate-navigator Ready Ready Preview Oct 7, 2026 1:21pm UTC
debatelab-staging Ready Ready Preview Oct 7, 2026 1:21pm UTC

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Free
  • Run ID: b9485ed1-23fe-4faa-8955-5231e2a55721
📥 Commits

Reviewing files that changed from the base of the PR and between 7c73df7 and 5b40cef.

📒 Files selected for processing (1)
  • e2e/full-stack/first-run.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The first-run end-to-end test now waits for the welcome-tour tooltip to settle below the current-debate card before starting a debate or skipping the tour. The wait checks both elements’ bounding boxes and times out after 15 seconds.

Changes

First-run welcome tour

Layer / File(s) Summary
Wait for the welcome-tour tooltip to settle
e2e/full-stack/first-run.spec.ts
A helper waits until the tooltip is below the current-debate card. Both fresh-account tour flows call it before interacting with the tour.

Estimated code review effort: 2 (Simple) | ~10 minutes

Architecture Summary

Architecture risk: 🔵 Low · up to 7c73d

The change affects 1 system.

Changed systems: e2e

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — e2e (service) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in e2e/model-matrix/generate.spec.ts: The test now imports chooseForMotion from the full-stack test helpers.
  • observed — Modified behavior in e2e/model-matrix/generate.spec.ts: After clicking Generate, the test calls chooseForMotion(page, "once") before awaiting the response.
  • observed — Modified behavior in e2e/production/canary.spec.ts: After starting case generation, the test now clicks the matching “use once” button in either supported confirmation dialog before checking the AI response.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing.

Comment @coderabbitai help to get the list of available commands.

@Programcode

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Programcode

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Programcode

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Programcode

Copy link
Copy Markdown
Owner Author

#95 carried this PR's commit 7c73df7 unchanged (as 9a2a520), so it reached main in 604194d. The model-matrix and canary specs on main now match this branch byte for byte. This PR can be closed, or merged as a no-op.

On a slow CI runner the mobile first-run spec clicked the tour's Start
debate button just before the tooltip slid below the Current Debate
card. The dialog never opened and the motion fill timed out. Both
first-run tests now wait for the tooltip's final position, below the
card, before they click it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Programcode
Programcode force-pushed the fix/e2e-motion-dialog branch from 7c73df7 to 5b40cef Compare October 7, 2026 13:19
@Programcode Programcode changed the title test(e2e): answer the motion dialog in model-matrix and the prod canary test(e2e): wait for the welcome tour to settle before clicking it Oct 7, 2026
@Programcode

Copy link
Copy Markdown
Owner Author

Rebased onto main: the original commit is already there via #95, so this PR now carries only the fix for the database-tests flake in first-run.spec.ts. Local ./.superset/db-gate.sh at 5b40cef passes (pgTAP pass, Playwright 71 passed / 1 skipped). Actions jobs are currently refused for billing, so there is no CI run on this head.

@Programcode
Programcode merged commit f9f3efc into main Oct 7, 2026
6 of 9 checks passed
@Programcode
Programcode deleted the fix/e2e-motion-dialog branch October 7, 2026 13:42

This branch was successfully deployed

3 active (1 outdated) deployments
Preview – debate-navigator — 5b40cef1 Deployed Oct 7, 2026 by vercel[bot]
Preview – debatelab-staging — 5b40cef1 Deployed Oct 7, 2026 by vercel[bot]
Preview — 7c73df7b Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants