Repository navigation
docs: add current debate implementation plans - #71
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds two implementation plans. One defines the Current Debate foundation, including navigation, migration, and verification. The other specifies AI context selection, feature prompts, handler modules, and related tests. ChangesCurrent Debate and AI context
Estimated code review effort: 2 (Simple) | ~10 minutes Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
|
|
||
| - Keep legacy cases, attacks, brainstorms, factoids, chats/messages, flowcharts, sparring sessions, and sources created within the last 30 days. | ||
| - Put that recent material in an Unsorted view. Suggest a debate using exact motion/title matches, but require the user to confirm attachment. | ||
| - Delete older legacy material and dependent source files/messages in the migration. |
There was a problem hiding this comment.
If the migration is implemented as directed, it will delete legacy work older than 30 days, including dependent files and messages, without requiring a backup or restore path. Users could permanently lose that work. Adam’s approval controls when the migration runs but does not make deleted data recoverable. Require verified preservation and recovery before merging this plan.
Artifacts
Read-only plan validation source
- The authored script reads the plan from Git revisions and checks deletion instructions and protections without running a migration.
- Running the script against HEAD^ showed that the proposed plan did not yet exist.
- Running the same script against HEAD found the deletion instruction and remote-authorization gate, but no stated recovery protection.
Ran code and verified through T-Rex
Prompt To Fix With AI
This is a comment left during a code review.
Path: .hermes/plans/2026-09-25_074255-current-debate-foundation.md
Line: 77
Comment:
**Protect work before deletion**
If the migration is implemented as directed, it will delete legacy work older than 30 days, including dependent files and messages, without requiring a backup or restore path. Users could permanently lose that work. Adam’s approval controls when the migration runs but does not make deleted data recoverable. Require verified preservation and recovery before merging this plan.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Comments Outside DiffThese findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.
|
Summary
Local checks
No product code, migrations, deployments, or runtime configuration changed.
Summary by CodeRabbit
Do not merge the foundation plan until it requires verified preservation and recovery before deletion.
Fix with agent prompt
Summary
This PR adds two implementation plans and changes no runtime code. The Current Debate plan directs a migration to delete older legacy work and dependent files without requiring a way to recover them. That protection needs to be added before the plan is merged.
Reviews (1) · Last reviewed commit: "docs: add current debate implementation ..."