Skip to content

docs: add current debate implementation plans - #71

Merged
Programcode merged 1 commit into
mainfrom
docs/current-debate-plans
Sep 25, 2026
Merged

Programcode merged 1 commit into
mainfrom
docs/current-debate-plans

Conversation

@Programcode

@Programcode Programcode commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add the Current Debate foundation plan and implementation prompt
  • add the debate-aware AI and module split plan and prompt
  • keep collaborative Workspace explicitly postponed

Local checks

  • cached diff check passed
  • plan files match the planning-worktree originals byte-for-byte
  • docs check is blocked by pre-existing broken links inside an unrelated nested .claude/worktrees checkout; neither new plan contains those paths

No product code, migrations, deployments, or runtime configuration changed.

Summary by CodeRabbit

  • Documentation
    • Added planning documents describing a unified debate workspace, including debate navigation, history, saved materials, and inactivity handling.
    • Documented proposed AI support for carrying debate context into existing features, reviewing context before use, and tailoring outputs to each feature.

RetriggerConfidence Score: 4/5

Do not merge the foundation plan until it requires verified preservation and recovery before deletion.

Fix All in CodexFindings

  1. P1 Protect work before deletion ▶
Fix with agent prompt
### Issue 1
.hermes/plans/2026-09-25_074255-current-debate-foundation.md:77
If the migration is implemented as directed, it will delete legacy work older than 30 days, including dependent files and messages, without requiring a backup or restore path. Users could permanently lose that work. Adam’s approval controls when the migration runs but does not make deleted data recoverable. Require verified preservation and recovery before merging this plan.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This PR adds two implementation plans and changes no runtime code. The Current Debate plan directs a migration to delete older legacy work and dependent files without requiring a way to recover them. That protection needs to be added before the plan is merged.

Reviews (1) · Last reviewed commit: "docs: add current debate implementation ..."

Copilot AI lite review requested due to automatic review settings September 25, 2026 09:37
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
debate-navigator Ready Ready Preview Sep 25, 2026 9:37am UTC

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: e1e2e6d2-dc21-4c25-a575-494df707542a

📥 Commits

Reviewing files that changed from the base of the PR and between ff64d57 and ca0a8bf.

📒 Files selected for processing (2)
  • .hermes/plans/2026-09-25_074255-current-debate-foundation.md
  • .hermes/plans/2026-09-25_074255-debate-ai-quality-modules.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds two implementation plans. One defines the Current Debate foundation, including navigation, migration, and verification. The other specifies AI context selection, feature prompts, handler modules, and related tests.

Changes

Current Debate and AI context

Layer / File(s) Summary
Current Debate scope and rules
.hermes/plans/2026-09-25_074255-current-debate-foundation.md
The plan defines personal debate ownership, motion and side coverage, source attachment, inactivity choices, and debate settings.
Navigation and debate views
.hermes/plans/2026-09-25_074255-current-debate-foundation.md
The plan specifies desktop and mobile navigation, Home and dashboard content, feature motion handling, and debate-scoped Library and History behavior.
Legacy migration and verification
.hermes/plans/2026-09-25_074255-current-debate-foundation.md
The plan specifies legacy material migration rules, tests and local checks, and implementation and submission constraints.
AI debate context selection
.hermes/plans/2026-09-25_074255-debate-ai-quality-modules.md
The plan specifies server-authorized context loading, relevant output selection, per-request Review overrides, size omission reporting, and one-off behavior.
AI prompts and handler modules
.hermes/plans/2026-09-25_074255-debate-ai-quality-modules.md
The plan specifies prompts for seven features, shared prompt rules, internal handler modules with stable endpoints, and associated test and submission requirements.

Estimated code review effort: 2 (Simple) | ~10 minutes

Architecture Summary

Architecture risk: 🔵 Low · up to ca0a8

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .hermes/plans/2026-09-25_074255-current-debate-foundation.md: Adds the product scope and rules: Current Debate is personal, follows the signed-in user, covers both sides, and receives results from the listed tools automatically. Each source belongs to one debate. For a different motion, users choose an existing debate, create one, or proceed without attachment; one-off work remains unattached unless later attached. After five days without meaningful work, app access is blocked pending one of three choices. Old debates persist until deleted, and each debate has structured settings and short instructions. Collaborative Workspace remains out of scope.
  • observed — Modified behavior in .hermes/plans/2026-09-25_074255-current-debate-foundation.md: Specifies desktop and mobile navigation, including a Current debate control and its popover actions; defines the Home launcher and Current Debate dashboard contents; requires feature forms to start with the debate motion without overwriting edited text and to offer Change or Use once; and scopes Library to the selected debate while History defaults to it without combining contexts.
  • observed — Modified behavior in .hermes/plans/2026-09-25_074255-current-debate-foundation.md: Defines a one-time migration that keeps legacy material from the last 30 days in an Unsorted view, suggests attachments only on exact motion/title matches and requires confirmation, and deletes older legacy material plus dependent files and messages. Prohibits permanent 30-day deletion for new debates and remote application of the destructive migration without explicit authorization for that environment.
  • observed — Modified behavior in .hermes/plans/2026-09-25_074255-current-debate-foundation.md: Requires database, UI/store, and desktop/mobile browser-journey tests covering ownership, switching, source isolation, the cutoff, blocking gate, mismatch choices, and automatic attachment. Specifies local verification commands and instructs recording local results without weakening tests to satisfy unreliable GitHub Actions.

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing.

Comment @coderabbitai help to get the list of available commands.


- Keep legacy cases, attacks, brainstorms, factoids, chats/messages, flowcharts, sparring sessions, and sources created within the last 30 days.
- Put that recent material in an Unsorted view. Suggest a debate using exact motion/title matches, but require the user to confirm attachment.
- Delete older legacy material and dependent source files/messages in the migration.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Protect work before deletion

If the migration is implemented as directed, it will delete legacy work older than 30 days, including dependent files and messages, without requiring a backup or restore path. Users could permanently lose that work. Adam’s approval controls when the migration runs but does not make deleted data recoverable. Require verified preservation and recovery before merging this plan.

Artifacts

Read-only plan validation source

  • The authored script reads the plan from Git revisions and checks deletion instructions and protections without running a migration.

Plan check before the PR

  • Running the script against HEAD^ showed that the proposed plan did not yet exist.

Plan check with the PR

  • Running the same script against HEAD found the deletion instruction and remote-authorization gate, but no stated recovery protection.

View artifacts

T-Rex Ran code and verified through T-Rex

Prompt To Fix With AI
This is a comment left during a code review.
Path: .hermes/plans/2026-09-25_074255-current-debate-foundation.md
Line: 77

Comment:
**Protect work before deletion**

If the migration is implemented as directed, it will delete legacy work older than 30 days, including dependent files and messages, without requiring a backup or restore path. Users could permanently lose that work. Adam’s approval controls when the migration runs but does not make deleted data recoverable. Require verified preservation and recovery before merging this plan.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Codex Fix in Cursor Fix in Claude Code

@greptile-apps

greptile-apps Bot commented Sep 25, 2026

Copy link
Copy Markdown

Comments Outside Diff

These findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.

  • P1 Specify recovery protection before deleting older legacy material ▶

    • Bug
      • The proposed migration permanently removes older legacy records and dependent source files/messages without a stated way to preserve or recover them. Adam’s required authorization for remote execution is a safeguard, but does not address data recovery.
    • Cause
      • The data-migration instructions at line 77 mandate deletion while the plan omits backup, export, snapshot, or rollback requirements.
    • Fix
      • Add a verified preservation and restore procedure before destructive execution, and make its successful completion a prerequisite alongside Adam’s environment-specific authorization.

@Programcode
Programcode merged commit 76e1869 into main Sep 25, 2026
7 of 10 checks passed

This branch was successfully deployed

1 active deployment
Preview — ca0a8bf3 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants