Repository navigation
fix(db): make legacy Data API grants explicit - #70
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (2)
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change documents explicit Data API grants for new public tables, adds grants for legacy tables and a sequence, and adds a pgTAP test for selected privileges. ChangesLegacy table grants
Estimated code review effort: 2 (Simple) | ~10 minutes Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
|
@coderabbitai review |
|
|
@coderabbitai review |
|
Summary
publictables and the keepalive sequence before Supabase changes its default permissions.ai_requestsread for the daily usage count;global_promptsstays server-only.Exact-head verification (
1b074b7)npm run verify: 1,034 unit tests and 226 desktop/mobile browser tests passed; six configured browser skips. Lint, typecheck, Edge tests, build, and service-worker smoke also passed../.superset/db-gate.sh: fresh migration replay, 305 pgTAP assertions, and 51 real-Auth desktop/mobile journeys passed; one configured skip. The local stack stopped afterward.LIVE_PROVIDERS=1 ./.superset/db-gate.sh: all eight live OpenRouter, Jev, and Exa journeys passed locally. The local stack stopped afterward.ai_requestsSELECT changed from false to true, anonymousai_requestsSELECT stayed false, and both client roles remained denied onglobal_prompts.supabase db push --dry-run --skip-vaultlisted exactly this one pending migration.Rollback
The production migration should not change existing ACLs. A pre-migration snapshot of public table and sequence ACLs is retained locally for comparison. If a privilege differs unexpectedly, use a scoped forward migration after checking that snapshot.