Skip to content

Complete English, Spanish, and Hungarian language parity - #58

Merged
Programcode merged 12 commits into
mainfrom
t3code/complete-hungarian-language-parity
Sep 21, 2026
Merged

Programcode merged 12 commits into
mainfrom
t3code/complete-hungarian-language-parity

Conversation

@Programcode

@Programcode Programcode commented Sep 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • complete English, Spanish, and Hungarian catalog parity across public, authenticated, admin, onboarding, and generated UI
  • propagate the selected language through every AI request path and enforce it in Edge Function validation and prompts
  • localize dates, numbers, speech recognition, generated artifacts, stable display identifiers, and Unicode-safe PDF exports
  • preserve account isolation during cold signed-out startup while retaining only the selected interface language
  • add browser, unit, collaboration, Edge, and catalog parity coverage plus focused documentation

Verification

  • npm run verify
  • 117 test files / 1,177 tests passed with coverage above project thresholds
  • 10 collaboration tests and 204 Edge Function tests passed
  • 210 Playwright tests passed, 2 skipped, and 8 timing-sensitive tests passed on retry in the local full run
  • focused desktop/mobile source-quality browser proof passed 2/2
  • generated Hungarian PDF rendered and visually inspected, including ő/ű
  • clean worktree and git diff --check

Verification boundaries

Local web behavior and credential-free gates are verified. Protected staging/live-provider checks were not run because staging credentials are unavailable. Real microphone dictation and native iOS were not exercised on this Linux host. Hungarian copy was model-reviewed, not signed off by a human fluent reviewer.

This PR is intentionally not merged pending Adam's explicit permission.

Summary by CodeRabbit

  • New Features

    • Expanded English, Spanish, and Hungarian localization across navigation, onboarding, administration, library, flowcharts, exports, source management, timers, dialogs, and error screens.
    • Added validated interface and AI-output language settings, with language-aware AI responses, speech recognition, dates, numbers, relative times, and PDF exports.
    • Added localized accessibility labels and screen-reader announcements throughout the application.
    • Added Hungarian coverage across public pages, authenticated workflows, responsive navigation, and dialogs.
  • Bug Fixes

    • Unsupported language values now safely fall back to English.
    • Route errors and AI-related notifications now display in the selected language.

Copilot AI lite review requested due to automatic review settings September 21, 2026 13:20
@Programcode

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@vercel

vercel Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
debate-navigator Ready Ready Preview Sep 21, 2026 2:02pm UTC

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

Preview blast radius → · Advanced feature

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: 923bdf2d-270f-4f44-868b-65af78dcb26a

📥 Commits

Reviewing files that changed from the base of the PR and between c91378e and f133e0c.

📒 Files selected for processing (83)
  • docs/architecture.md
  • docs/testing.md
  • e2e/home-navigation.spec.ts
  • e2e/hungarian-parity.spec.ts
  • e2e/navigation-performance.spec.ts
  • e2e/quality-backlog.spec.ts
  • e2e/search-quality.spec.ts
  • e2e/sparring.spec.ts
  • src/App.tsx
  • src/components/LanguageSwitcher.tsx
  • src/components/admin/AdminAnnouncements.tsx
  • src/components/features/ask/AskChat.tsx
  • src/components/features/attack/AttackResults.tsx
  • src/components/features/onboarding/OnboardingTour.tsx
  • src/components/features/shared/SourceQualityList.tsx
  • src/components/features/sparring/SparringRound.tsx
  • src/components/landing/Footer.tsx
  • src/components/landing/Navbar.tsx
  • src/components/landing/UseCases.tsx
  • src/components/layout/AppLayout.tsx
  • src/components/ui/dialog.tsx
  • src/components/ui/sheet.tsx
  • src/components/ui/streaming-indicator.tsx
  • src/components/ui/toast.tsx
  • src/hooks/use-speech-to-text.ts
  • src/i18n.ts
  • src/lib/ai/client.ts
  • src/lib/ai/streaming.ts
  • src/lib/date-format.ts
  • src/lib/languages.ts
  • src/lib/pdf-export-utils.ts
  • src/lib/stores/session-store.ts
  • src/lib/stores/settings-store.ts
  • src/lib/supabase/AuthProvider.tsx
  • src/locales/en.json
  • src/locales/es.json
  • src/locales/hu.json
  • src/pages/AdminPage.tsx
  • src/pages/CrossfirePage.tsx
  • src/pages/FlowchartPage.tsx
  • src/pages/HistoryPage.tsx
  • src/pages/LibraryPage.tsx
  • src/pages/SettingsPage.tsx
  • src/pages/SharedPage.tsx
  • src/pages/SourcesPage.tsx
  • src/pages/TimerPage.tsx
  • src/test/ai/client.test.ts
  • src/test/ai/control-payload-matrix.test.ts
  • src/test/ai/crossfire-client.test.ts
  • src/test/ai/streaming.test.ts
  • src/test/app-route-analytics-error-boundary.test.tsx
  • src/test/auth/AuthProvider.behavior.test.tsx
  • src/test/components/AdminAnnouncements.test.tsx
  • src/test/components/AppLayout.test.tsx
  • src/test/components/AskChat.test.tsx
  • src/test/components/AttackResults.test.tsx
  • src/test/components/AutoSavedSourcesUndo.test.tsx
  • src/test/components/SourceQualityList.test.tsx
  • src/test/components/StreamingIndicator.test.tsx
  • src/test/date-format.test.ts
  • src/test/i18n.test.ts
  • src/test/pages/AdminPage.test.tsx
  • src/test/pages/FlowchartPage.test.tsx
  • src/test/pages/HistoryPage.test.tsx
  • src/test/pages/LibraryPage.test.tsx
  • src/test/pages/SourcesPage.test.tsx
  • src/test/pdf-export-utils.test.ts
  • src/test/session-store.test.ts
  • src/test/stores/settings-store-additional.test.ts
  • src/test/stores/settings-store-branches.test.ts
  • src/test/supabase/prompt-builder.test.ts
  • src/test/use-speech-to-text.test.tsx
  • supabase/functions/_shared/control-enforcement.test.ts
  • supabase/functions/_shared/control-enforcement.ts
  • supabase/functions/_shared/prompts.ts
  • supabase/functions/ai-stream/handler_test.ts
  • supabase/functions/ai-stream/index.ts
  • supabase/functions/ai-stream/prompt.test.ts
  • supabase/functions/ai/control-matrix.test.ts
  • supabase/functions/ai/handler-research.test.ts
  • supabase/functions/ai/index.ts
  • supabase/functions/ai/prompt-builder.test.ts
  • supabase/functions/ai/prompt-builder.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds centralized English, Spanish, and Hungarian localization. It applies language settings to interface content, formatting, speech recognition, PDF exports, AI requests, backend prompts, validation, and automated tests.

Changes

Application localization

Layer / File(s) Summary
Language foundation
src/lib/languages.ts, src/i18n.ts, src/lib/stores/settings-store.ts, src/lib/date-format.ts, src/hooks/use-speech-to-text.ts
Adds shared language metadata, validation, document-language updates, localized formatting, and language-aware speech recognition.
Localized interface behavior
src/App.tsx, src/components/*, src/pages/*, src/locales/*, src/lib/pdf-export-utils.ts
Replaces hardcoded interface text with translations across navigation, route errors, admin screens, pages, accessibility labels, PDF exports, and autosaved titles.
AI output-language pipeline
src/lib/ai/*, supabase/functions/ai/*, supabase/functions/ai-stream/*, supabase/functions/_shared/*
Validates language controls, adds selected output languages to AI requests, and inserts explicit language instructions into backend prompts.
Validation and regression coverage
src/test/*, e2e/*, docs/*
Adds Hungarian localization tests for interface content, formatting, speech, exports, AI payloads, backend validation, navigation, runtime errors, and browser parity.

Estimated code review effort: 5 (Critical) | ~90 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant LanguageSettings
  participant Application
  participant AIClient
  participant SupabaseAI
  User->>LanguageSettings: select interface and output languages
  LanguageSettings->>Application: apply validated interface language
  Application->>AIClient: create localized AI request
  AIClient->>SupabaseAI: send validated language control
  SupabaseAI->>AIClient: generate output with language instruction
Loading

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Programcode

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Programcode

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@Programcode
Programcode merged commit 8a938e1 into main Sep 21, 2026
7 checks passed

This branch was successfully deployed

1 active deployment
Preview — f133e0cd Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants