fix: resolve retained UI bugs by Programcode · Pull Request #45 · Programcode/DebateOwl

Programcode · 2026-09-19T16:50:37Z

Summary

remove the stale hardcoded Sources consultation date
give each Factoids save control a localized, claim-specific accessible name
make Generate, Attack, Brainstorm, Factoids, and Ask headings reuse their localized navigation labels
confirm Flowchart node deletion and show localized success feedback
clear stale node selection when loading a saved flowchart
add focused component and desktop/mobile regression coverage

Before/after proof

Watch the 84.9-second desktop/mobile proof video
The video includes the failing before states, actual desktop/mobile navigation clicks, the Factoids DOM aria-label, Flowchart confirmation, and the visible mobile deletion toast.

Verification

focused Vitest: 22 passed
lint: passed
typecheck: passed
full coverage: 104 files, 1,023 tests passed; 90.29% statements, 82.81% branches, 92.26% functions, 94.3% lines
production build: passed
focused Playwright on isolated port 18084: 12 passed across desktop and mobile Chromium
independent release review: no remaining findings

No production deployment or data mutation is included.

Summary by CodeRabbit

New Features
- Added confirmation and success feedback when deleting flowchart nodes, including mobile interactions.
- Save actions in Factoids now identify the specific fact being saved.
- Added localized flowchart deletion messages in supported languages.
Bug Fixes
- Removed outdated consultation dates from source citations.
- Standardized page headings with localized navigation labels.
Tests
- Expanded automated coverage for localization, Factoids saving, source citations, and flowchart deletion behavior.

vercel · 2026-09-19T16:50:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
debate-navigator	Ready	Preview	Sep 19, 2026 5:07pm UTC

coderabbitai · 2026-09-19T16:50:47Z

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: 388f52e4-362c-4705-9ae4-c03572fedc2d

📥 Commits

Reviewing files that changed from the base of the PR and between a7ff138 and e76d248.

📒 Files selected for processing (2)

src/pages/FlowchartPage.tsx
src/test/pages/FlowchartPage.test.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The pull request updates localized headings and factoid save labels, removes stale source consultation text, adds confirmed flowchart node deletion, and expands unit and end-to-end coverage.

Changes

Quality backlog improvements

Layer / File(s)	Summary
Localized headings and source citations `src/pages/{AskPage,AttackPage,BrainstormPage,FactoidsPage,GeneratePage}.tsx`, `src/pages/SourcesPage.tsx`, `e2e/quality-backlog.spec.ts`, `src/test/pages/{AttackPage,SourcesPage}.test.tsx`	Page headings use shared navigation keys. Source links no longer show the fixed consultation date. Tests cover navigation and source output.
Factoid save labeling `src/components/features/factoids/FactoidsResults.tsx`, `src/locales/{en,es,hu}.json`, `src/test/components/FactoidsResults.test.tsx`, `e2e/quality-backlog.spec.ts`	The save button has a localized accessible label that includes the factoid claim. Tests verify the label.
Flowchart node deletion confirmation `src/pages/FlowchartPage.tsx`, `src/locales/{en,es,hu}.json`, `src/test/pages/FlowchartPage.test.tsx`, `e2e/quality-backlog.spec.ts`	Delete actions open a localized confirmation dialog. Confirmation removes the selected node and connected edges and shows a success toast. Loading a flowchart clears stale selection. Tests cover cancellation, confirmation, and mobile interaction.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant FlowchartPage
  participant ReactFlowState
  participant Toast
  User->>FlowchartPage: Select delete action
  FlowchartPage->>User: Show confirmation dialog
  User->>FlowchartPage: Confirm deletion
  FlowchartPage->>ReactFlowState: Remove node and connected edges
  FlowchartPage->>Toast: Show success feedback

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing.

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Copilot review overview

🔵 Needs a closer look

Flowchart deletion can report success without deleting when a stale node selection remains after loading a saved flowchart.

Review effort: Lite
Findings: None

What changed in this PR

This pull request fixes retained UI issues involving stale metadata, localization, accessibility, and Flowchart deletion feedback.

Changes:

Removed the stale Sources consultation date.
Reused localized navigation labels for page headings.
Added claim-specific Factoids labels and localized Flowchart deletion feedback.
Added focused and desktop/mobile regression coverage.

File	Description
`src/test/pages/SourcesPage.test.tsx`	Tests Sources metadata behavior.
`src/test/pages/FlowchartPage.test.tsx`	Tests Flowchart deletion behavior.
`src/test/pages/AttackPage.test.tsx`	Tests localized Attack heading behavior.
`src/test/components/FactoidsResults.test.tsx`	Tests accessible Factoids save labels.
`src/pages/SourcesPage.tsx`	Removes stale consultation date.
`src/pages/GeneratePage.tsx`	Reuses the localized navigation heading.
`src/pages/FlowchartPage.tsx`	Adds deletion confirmation and localized feedback.
`src/pages/FactoidsPage.tsx`	Reuses the localized navigation heading.
`src/pages/BrainstormPage.tsx`	Reuses the localized navigation heading.
`src/pages/AttackPage.tsx`	Reuses the localized navigation heading.
`src/pages/AskPage.tsx`	Reuses the localized navigation heading.
`src/locales/hu.json`	Adds localized UI strings.
`src/locales/es.json`	Adds localized UI strings.
`src/locales/en.json`	Adds localized UI strings.
`src/components/features/factoids/FactoidsResults.tsx`	Adds claim-specific accessible save labels.
`e2e/quality-backlog.spec.ts`	Adds desktop/mobile regression coverage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Programcode · 2026-09-19T17:06:20Z

Resolved the stale-selection edge case noted in Copilot review: loading a saved flowchart now clears the previous node selection before exposing edit/delete actions. Added a regression test that reproduced the no-op deletion/success-toast path. Fresh local verification: 1,023 coverage tests, lint, typecheck, build, and 12 desktop/mobile focused E2E tests all pass.

Programcode · 2026-09-19T17:20:04Z

@coderabbitai review

coderabbitai · 2026-09-19T17:20:09Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Programcode · 2026-09-19T17:40:06Z

@coderabbitai review

coderabbitai · 2026-09-19T17:40:11Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Programcode · 2026-09-19T17:52:14Z

@coderabbitai review

coderabbitai · 2026-09-19T17:52:20Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

fix: resolve retained UI bugs

a7ff138

Copilot AI lite review requested due to automatic review settings September 19, 2026 16:50

vercel Bot deployed to Preview September 19, 2026 16:50

View deployment

Copilot started reviewing on behalf of Programcode September 19, 2026 16:51

View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

fix: clear stale flowchart selection

e76d248

vercel Bot deployed to Preview September 19, 2026 17:07

View deployment

Programcode merged commit e1e0070 into main Sep 19, 2026
7 checks passed

Programcode deleted the t3code/fix-retained-ui-bugs branch September 19, 2026 18:25

Programcode mentioned this pull request Oct 3, 2026

test: cut tests that can't catch a regression, fix the misbuilt ones #107

Merged

Navigation Menu

Repository navigation

fix: resolve retained UI bugs - #45

fix: resolve retained UI bugs#45
Programcode merged 2 commits into
mainfrom
t3code/fix-retained-ui-bugs

Programcode commented Sep 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Sep 19, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

Copilot AI left a comment

Uh oh!

Programcode commented Sep 19, 2026

Uh oh!

Programcode commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

Uh oh!

Programcode commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

Uh oh!

Programcode commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Programcode commented Sep 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Before/after proof

Verification

Summary by CodeRabbit

Uh oh!

vercel Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Programcode commented Sep 19, 2026

Uh oh!

Programcode commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Programcode commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Programcode commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Programcode commented Sep 19, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Sep 19, 2026 •

edited

Loading

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading