Repository navigation
fix: avoid 403 during settings migration - #44
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe settings migration now updates only ChangesSettings migration persistence
Estimated code review effort: 2 (Simple) | ~10 minutes Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
Normal settings updates can still fail with 403 because authenticated INSERT permission is revoked.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR avoids authenticated INSERT attempts during settings migration by using a permitted targeted update.
Changes:
- Replaced migration-time
upsertwith a user-scopedUPDATE. - Updated tests for targeted updates and canonical no-op behavior.
- Normal settings changes still use
upsert, leaving a critical 403 issue unresolved.
File summaries
| File | Summary |
|---|---|
src/test/settings-store.test.ts |
Verifies update behavior and canonical-config no-op behavior. |
src/lib/stores/settings-store.ts |
Uses targeted updates for migration; regular persistence still uses upsert. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| feature_configs: mergedConfigs, | ||
| custom_system_prompt: customSystemPrompt ?? null, | ||
| }); | ||
| await persistMigratedFeatureConfigs(mergedConfigs); |
Summary
Verification
Summary by CodeRabbit