Repository navigation
Ignore wallet-provider {code, message} rejections in Sentry - #291
Merged
Merged
Conversation
JAVASCRIPT-REACT-B is an unhandled rejection of a plain { code, message }
object on the home page, from one Avast Secure Browser user, with no stack
frames. That shape is what injected EIP-1193 wallet providers reject with.
No code in src/, packages/, the built bundle, or Jam's recorder scripts
rejects with it, so filter that exact message.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry issue: JAVASCRIPT-REACT-B.
UnhandledRejection: Object captured as promise rejection with keys: code, messageon/, from one Avast Secure Browser 154 user on Windows. The event has no stack frames.Cause
This is very likely a page-world script that the browser or an extension injected, not our code. Avast Secure Browser ships a crypto wallet, and wallet providers that follow EIP-1193 reject with a plain
{ code, message }object. I couldn't read the event itself because there's no Sentry API token on the VPS, so this comes from the code:src/orpackages/rejects with a plain object. The only barethrow errorsites rethrow Supabase errors, and those are realErrorsubclasses in supabase-js 2.114 (PostgrestError,AuthError,FunctionsError).dist/assetsbundle forreject({...}),throw {...}and{code:…,message:…}literals found nothing.recorder.jsandcapture.jsonly build{code, message, …}objects inside zod issue reports. They don't reject with them./route doesn't hydrate any store.To confirm, open the event's
extra.__serialized__in Sentry. A numeric code like 4xxx or -32xxx, or achrome-extension://breadcrumb, settles it.Change
One more anchored entry in
ignoreErrorsinsrc/lib/observability.ts. It matches only an object whose own keys are exactlycodeandmessage. Supabase-shaped objects (code, details, hint, message) and real errors still report. If our own code ever rejected with exactly this shape, the filter would hide that too. The bundle has no such producer today.Checks
npm run lint,npm run typecheck,npm test(94 guards): pass.eventFiltersIntegrationwith the new list. The target message is dropped, whilecode, details, hint, messageand aTypeErrorare kept.npm run verifyand the browser suites, which can't exercise a Sentry filter.Not merging: this is a production config change in
src/lib/observability.ts, so it's Adam's call.🤖 Generated with Claude Code