Repository navigation
Triage the Nov 1 bug bash: name sides on Current Debate, reject blank input, stop false-red explore jobs - #290
Merged
Merged
Conversation
…false-red explore jobs
- Current Debate rows show the side (a side column leaves out its own), so a
Pro and a Con case saved the same minute no longer read as one case listed
twice. Load buttons name the kind and side as well as the motion.
- Generate, Brainstorm and Attack treat a motion or argument of only spaces as
blank instead of spending an AI request on it.
- The Sparring progress bar's accessible name fills in the time instead of
reading "{{time}} remaining".
- The bug-bash Exploration step passes with a warning when e2e explore exits 1
with issues recorded, and fails on any other error, in place of
continue-on-error, which marked every job red and also hid real harness
failures.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triage of the 2026-11-01 bug bash, run 41303539137 on
8f20171d.Why all four jobs were red
The run wasn't broken.
e2e exploreexits 1 whenever it records an issue, and each persona recorded some, so every job went red at the Exploration step.continue-on-error: truethen kept the workflow green:gh run listshows run 41303539137 assuccess. Nothing in the stack, the browser or the model calls failed.The harness still needed fixing. Because
continue-on-errorhides any exit code, a crash, a missing model key or a dead stack looked the same as "found bugs". The Exploration step now readsreport.json. Exit 1 with at least one issue recorded passes with a warning annotation. Every other non-zero exit fails the job. I tested thejqcount against this run's coach report (9 issues, matching the log) and against a missing report (0, so the job fails).Coach findings: what actually happened
The data was right every time. The action trace and screenshots show:
Load (1 of 2), the newest row (Against, 11:52), and then reported that it had clicked the 11:51 row. That is the "Generate case saving" step failure.The confusion came from the Current Debate page. Every row was titled with the motion and read
Case · 1 Nov 2026, 11:52, with no side. Two different cases saved in the same minute therefore looked like one case listed twice, and every Load button had the same accessible name.Findings by job
coach, desktop. 9 issues, 2 warnings.
Load (1 of 4)in History, so all 4 cases were there.edge-input, desktop. 6 issues, 8 warnings.
z.string().min(1)accepted spaces.createDebaterejects. The whitespace fix stops this from happening.hungarian, mobile. 9 issues, 1 warning.
{{time}} van hátraon the Sparring timer (medium): real bug, fixed. The progress bar'saria-labeldidn't passtime.-ban/-ben Second contention(medium, low): fake provider. Its canned output is English. Live mode writes in the chosen output language.#1Fares…andElőadáscsak írásbanrun together (low): lead. Seen in the accessibility snapshot, where adjacent elements have no space between them. The screen may be fine. Needs a check.first-timer, desktop. 8 issues, 2 warnings.
{{time}} remaining(medium): real bug, fixed. Same as the Hungarian finding.What changed
src/pages/CurrentDebatePage.tsx: rows readCase · In favor · 1 Nov 2026, 11:52. A side column leaves out its own side, so a both-sides item there reads "Both sides". Load buttons are named "Load , , ".packages/core/src/ai/schemas/{generate,brainstorm,attack}.ts: the motion and argument are trimmed before the required check. These are client form schemas; no Edge Function imports them.src/components/features/sparring/SparringRound.tsx: the timer progress bar label getstime..github/workflows/agentic-e2e.ymlanddocs/testing.md: the Exploration step logic described above.e2e/quality-backlog.spec.tsgains one spec showing that spaces-only input in Generate and Attack shows the required message and sends no AI request. It failed before the fix. The Current Debate recipe ande2e/full-stack/current-debate.spec.tseach gain one assertion that a Recent work row names its side. I updated the skill'sfeatures/current-debate.mdto match.No migrations, no Edge Function changes, no production changes.
Verification
npx playwright test e2e/quality-backlog.spec.tson desktop and mobile Chromium: 22 passed. The new spec failed before the schema fix, at "Motion is required" not visible. The existing 360 px Current Debate fit test still passes with the longer rows.verify.sh drive recipes/current-debateondesktop-chromiumandmobile-chromiumagainst the local stack (fake provider): 3/3 passed on each.npm run lint,npm run typecheck,npm test(94 guards),npm run docs:check: pass.npm run verifyat the final head: all 9 steps passed in 98.9 s (docs, jargon, typecheck, guards, lint, edge, build, smoke, sw-offline). Local pass only; CI runs on this push.gh workflow run agentic-e2e.yml --ref t3/agentic-bugbash-1101 -f explore="…" -f persona=coach, will exercise the new Exploration step on GitHub.Merge rule
Not low-risk under AGENTS.md: it touches
.github/andpackages/core. It needs Adam's OK to merge.🤖 Generated with Claude Code