Repository navigation
Fix the production canary's Ask model picker step - #282
Merged
Merged
Conversation
The production canary's streamed-answer test looked for the Ask model picker on the page, but Ask keeps it in the Options popover, which starts closed. Open Options first, pick Claude Haiku 5.5, then close it before typing. The test also waits up to 90 s for the stream, so give it its own 120 s timeout instead of the 30 s default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled Production canary fails on
e2e/production/canary.spec.ts"the canary account gets a streamed answer from a real model" (run 41064327840, both attempts).pickBasicDefault(page, "ask")waits 30 s for theSelect AI model for askcombobox and never finds it.Cause. On
/app/ask, the model picker sits inside the Options popover inAskChat.tsx, and that popover starts closed, so the combobox isn't on the page until someone opens Options. The app works; the test skipped a step. The AI tests in the canary run only on the daily schedule, and earlier scheduled runs were blocked on billing, so this is the first real run since the picker moved.Fix. The test now clicks the Options button first, picks Claude Haiku 5.5, and presses Escape to close the popover before typing. The live research spec and the verify-debatelab recipes already open this popover the same way. The test also waits up to 90 s for the stream but had the 30 s default test timeout, so it now sets 120 s, as the generate test sets its own.
Checks.
event: finalfromai-stream, and it confirmed the picker is gone from the page once the popover closes.npm run verifypassed at this head.Test-only change. Left unmerged on request; Adam merges.
🤖 Generated with Claude Code