Repository navigation
fix: allow Jam uploads in CSP and drop ignored sendDefaultPii - #28
Conversation
PR #15 added https://*.jam.dev to script-src and frame-src, so the recorder loads in production, but connect-src was never updated. The recorder had no route to upload a capture. Add the origin to connect-src in both vercel.json and nginx.conf, which the config test already requires to stay identical. Sentry ignores sendDefaultPii entirely whenever dataCollection is set, so the line read as a PII control that does nothing. Remove it and leave the dataCollection block as the single source of truth. queryParams is correct at the pinned @sentry/core 10.65.0; urlQueryParams does not exist until 10.68. Both fixes get an assertion that fails without them.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change adds Jam.dev origins to CSP directives and removes the deprecated Sentry ChangesConfiguration updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR adds the required Jam upload origin to the connection policy and removes an ineffective Sentry setting; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches📝 Generate docstrings
Comment |
* docs: rewrite plans around remaining work only Rewrite eleven plans to cover only missing work, trim the bug backlog to four reproducible items, add the PR #11 salvage plan, and delete completed and obsolete plans. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: reconcile plans with merged work through PR #28 Delete five plans whose implementations shipped and were verified against origin/main at 79b65ca: admin announcements (#19, #26), agent verification loop (#21, #26, #27), analytics and error tracking (#16, #18, #22-#25, #28), animation polish (#20), and search quality (#17). Trim the Supabase staging plan to the admin environment switcher, the only unshipped code in it. Refresh snapshot headers on the remaining plans after confirming PRs #16-#28 did not touch their scope, and re-verify all four bug backlog items and their line references. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: bump dependencies, GitHub Actions, and CI tool versions Upgrades react-router-dom (6->7), pdfjs-dist (5->6), @capacitor/cli, Deno/Supabase CLI versions in CI, and pins Actions to their latest major releases (checkout, setup-node, upload/download-artifact, Docker actions). Updates tests and the Deno assert shim import for the router v7 API and jsr:@std/assert. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
* docs: rewrite plans around remaining work only Rewrite eleven plans to cover only missing work, trim the bug backlog to four reproducible items, add the PR #11 salvage plan, and delete completed and obsolete plans. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: reconcile plans with merged work through PR #28 Delete five plans whose implementations shipped and were verified against origin/main at 79b65ca: admin announcements (#19, #26), agent verification loop (#21, #26, #27), analytics and error tracking (#16, #18, #22-#25, #28), animation polish (#20), and search quality (#17). Trim the Supabase staging plan to the admin environment switcher, the only unshipped code in it. Refresh snapshot headers on the remaining plans after confirming PRs #16-#28 did not touch their scope, and re-verify all four bug backlog items and their line references. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: rebuild project documentation * fix: address documentation review findings --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Follow-up review of the PRs merged 2026-08-31. Two gaps survived that batch.
Jam recorder cannot upload
PR #15 added
https://*.jam.devtoscript-srcandframe-src, and@jam.dev/sdkis a production dependency wired into
AuthProvider, sobootstrap.tsloads therecorder for real users. But
connect-srcwas never updated — the recorder loadsand then has no route to send a capture.
Added the origin to
connect-srcin bothvercel.jsonandnginx.conf. Theexisting config test already asserts the two policies are byte-identical, so
they cannot drift.
sendDefaultPiiwas dead configAt the pinned
@sentry/core10.65.0,sendDefaultPiiis deprecated and, per itsown type docs, "if both
sendDefaultPiianddataCollectionare set,sendDefaultPiiwill be ignored." SincedataCollectionis set, the line was aPII control that did nothing — worse than absent, because it reads as protection.
Removed;
dataCollectionis now the single source of truth.Note:
queryParamsis correct at 10.65.0.urlQueryParamsdoes not existuntil 10.68.0, so no rename here.
Verification
Both fixes have an assertion that fails without them (confirmed by reverting each
fix with the tests in place — both went red, then green again once restored).
Summary by CodeRabbit
New Features
Bug Fixes
Tests