Repository navigation
Ask reads a saved case's R2 and Conclusor paragraphs in full - #256
Merged
Merged
Conversation
The case summary cut backing-up paragraphs and why-we-win reasons to 240 characters and kept only 3 If-they-say answers at 200. They now pass in full (2,000-character safety bound each, up to 8 answers). A case may contribute 12,000 characters, and all saved results 16,000.
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 42 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask (and Generate's debate context) read a saved case through a short summary that cut every R2 "backing up" paragraph and Conclusor "why we win" reason to 240 characters, and every "If they say" answer to 200, keeping only 3 answers. Since #244, those paragraphs run ~1,000-1,200 characters each, so Ask saw only their first sentence.
Change (
supabase/functions/_shared/debate-context.ts)MAX_CASE_DIGEST_CHARS). Other result types keep their 2,500. A real 6-answer R2 (r2-case.jsonfrom Generate writes cases the way school debaters prepare them #244) comes to 9,954 characters with nothing shortened.Only
aiandai-streamimport this file (checked withdeno info). Both get redeployed after merge.Checks
npm run verifypassed locally: 96 + 5 unit test files, Edge 493/493, docs, lint, typecheck, build, the offline service-worker test and smoke 47/47.