Skip to content

fix: suppress synthetic observability alert - #25

Merged
Programcode merged 1 commit into
mainfrom
t3code/fix-synthetic-observability-alert
Aug 31, 2026
Merged

Programcode merged 1 commit into
mainfrom
t3code/fix-synthetic-observability-alert

Conversation

@Programcode

@Programcode Programcode commented Aug 31, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • suppress only the exact synthetic observability verification sentinel through the native Sentry anchored error filter
  • preserve longer near-matches and unrelated production errors
  • add configuration and real-SDK transport regression coverage

Root cause

The reported event was an injected verification exception, not a privacy-page crash. The sentinel is absent from repository history and installed SDK sources, its stack is an eval/setTimeout browser error, Sentry observability merged at 17:22 UTC, and the alert appeared at 17:40 UTC. Ordinary privacy-page navigation remains clean.

Verification

  • focused regression was red before the fix
  • 95 Vitest files / 958 tests passed with coverage
  • lint and TypeScript passed
  • production build passed
  • 124 desktop/mobile Chromium tests passed on isolated loopback port 18081
  • real Sentry SDK transport test proves exact sentinel dropped, longer near-match sent, unrelated real error sent
  • independent standards and incident-contract reviews clear
  • git diff and secret-pattern scans clean

The full verify command completed all static stages. Its browser phase could not bind hardcoded port 18080 because another active isolated DebateLab worktree owned it. The identical browser command passed on port 18081 without disrupting that worktree.

Summary by CodeRabbit

  • Bug Fixes

    • Prevented synthetic observability verification errors from appearing in Sentry error reports.
    • Preserved reporting for genuine errors and similarly named exceptions.
  • Tests

    • Added coverage to verify observability error filtering and ensure Sentry remains properly closed after testing.

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
debate-navigator Ready Ready Preview Aug 31, 2026 7:50pm

@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e3318412-74f7-4b13-aafd-53c771bb4590

📥 Commits

Reviewing files that changed from the base of the PR and between 5629adf and d8dc7c0.

📒 Files selected for processing (3)
  • src/lib/observability.ts
  • src/test/observability.test.ts
  • src/test/sentry-event-filter.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Sentry initialization now ignores the exact synthetic observability verification error. Tests verify the configuration and confirm that similarly prefixed and real errors remain transmitted.

Changes

Observability filtering

Layer / File(s) Summary
Configure and validate Sentry filtering
src/lib/observability.ts, src/test/observability.test.ts, src/test/sentry-event-filter.test.ts
Sentry ignores the exact Synthetic observability verification error. Tests verify the initialization rule and event filtering behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to d8dc7

This PR narrowly suppresses the exact synthetic observability sentinel while preserving near-matches and unrelated errors; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: suppressing the synthetic observability alert. It matches the Sentry filtering configuration and related tests.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@Programcode

Copy link
Copy Markdown
Owner Author

Merge-gate exception: GitHub Actions run 33432771216 failed before runner allocation. The job has no runner, zero steps, and no logs, so this is the documented account-level Actions exception rather than a submitted-code failure.

Current-head local proof: Node 22 lint and typecheck passed; 95 Vitest files and 958 tests passed with coverage; production build passed; all 124 desktop/mobile Chromium tests passed on isolated port 18081. Vercel and CodeRabbit passed, CodeRabbit generated no actionable comments, and unresolved review threads are zero.

@Programcode
Programcode merged commit 77a7bef into main Aug 31, 2026
3 of 4 checks passed
@Programcode
Programcode deleted the t3code/fix-synthetic-observability-alert branch August 31, 2026 19:54
Programcode added a commit that referenced this pull request Sep 6, 2026
* docs: rewrite plans around remaining work only

Rewrite eleven plans to cover only missing work, trim the bug backlog to
four reproducible items, add the PR #11 salvage plan, and delete completed
and obsolete plans.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* docs: reconcile plans with merged work through PR #28

Delete five plans whose implementations shipped and were verified against
origin/main at 79b65ca: admin announcements (#19, #26), agent verification
loop (#21, #26, #27), analytics and error tracking (#16, #18, #22-#25, #28),
animation polish (#20), and search quality (#17).

Trim the Supabase staging plan to the admin environment switcher, the only
unshipped code in it. Refresh snapshot headers on the remaining plans after
confirming PRs #16-#28 did not touch their scope, and re-verify all four
bug backlog items and their line references.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* chore: bump dependencies, GitHub Actions, and CI tool versions

Upgrades react-router-dom (6->7), pdfjs-dist (5->6), @capacitor/cli,
Deno/Supabase CLI versions in CI, and pins Actions to their latest
major releases (checkout, setup-node, upload/download-artifact,
Docker actions). Updates tests and the Deno assert shim import for
the router v7 API and jsr:@std/assert.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Programcode added a commit that referenced this pull request Sep 6, 2026
* docs: rewrite plans around remaining work only

Rewrite eleven plans to cover only missing work, trim the bug backlog to
four reproducible items, add the PR #11 salvage plan, and delete completed
and obsolete plans.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* docs: reconcile plans with merged work through PR #28

Delete five plans whose implementations shipped and were verified against
origin/main at 79b65ca: admin announcements (#19, #26), agent verification
loop (#21, #26, #27), analytics and error tracking (#16, #18, #22-#25, #28),
animation polish (#20), and search quality (#17).

Trim the Supabase staging plan to the admin environment switcher, the only
unshipped code in it. Refresh snapshot headers on the remaining plans after
confirming PRs #16-#28 did not touch their scope, and re-verify all four
bug backlog items and their line references.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* docs: rebuild project documentation

* fix: address documentation review findings

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — d8dc7c09 Deployed Aug 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant