Repository navigation
Stop mentioning API keys on the Account card; audit confirms BYOK is gone (T16) - #216
Merged
Merged
Conversation
The Account card described itself as "API keys are managed securely on the server", a leftover from the prototype that let users paste their own provider keys. Nothing in the app offers that any more, so describe what the card holds: how you sign in and a copy of your data. EN, HU and ES. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Hungarian line could be read as "a copy of your sign-in"; say how you sign in and offer a copy of your saved data. The Spanish line now reuses "lo guardado en tu cuenta" from the Your data row, which reads the same in Spain and Latin America. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
Note 🎁 Summarized by CodeRabbit Free
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T16: users are no longer offered bring-your-own-key (BYOK). The audit found that the app already stopped offering it in January 2026. The one thing left was a line on the Settings Account card ("API keys are managed securely on the server."). This PR replaces that line in EN, HU and ES. No code, Edge Function or migration changes.
What changed
settings.accountDescinsrc/locales/{en,hu,es}.jsonnow describes what the Account card holds:SettingsPage.tsxis untouched, to stay clear of T6 (fix/t6-usage-pricing). T6 has no locale hunk within ten lines of this key.Where BYOK stands
index.htmlorpublic/offers or mentions user keys, in any of the three locales (includingsrc/locales/tools/). A bad-key error from a provider shows "not configured correctly. Please inform the site admin." A paste-your-key form existed only in the pre-Supabase prototype, from 2026-01-23 (78931c85) to 2026-01-29 (86205bdc), and it kept keys in localStorage.legacy_freebilling tier, so there was nothing to put BYOK behind.public.api_keys: app code only ever deleted rows and never inserted any, and no Edge Function has ever read the table. This PR leaves the table, its rows, its RLS policy and its grants alone.user_settings.feature_configs:normalizeFeatureConfigkeeps only provider, model and reasoning effort, which is already the case on main.debate-trainer-settings: the store still copies an old prototypeapiKeysvalue through, and nothing reads it. This PR doesn't touch it, per "don't delete stored keys".OPENROUTER_API_KEY,EXA_API_KEY,ELEVENLABS_API_KEY). The "BYOK" in_shared/cost.tsand_shared/provider-routing.tsis DebateLab's own Anthropic key attached to its OpenRouter account, not a user feature, so it stays. No functions to deploy.Verification
All local; CI on this head is the separate signal.
npm run verifyata7132d0c: exit 0. Vitest 586/586 (81 files), collaboration 30/30, Deno 457 passed / 0 failed, Playwright desktop Chromium smoke 47/47.verify-debatelabin fake mode,recipes/account.spec.tsandrecipes/model-defaults.spec.ts: 8/8 ondesktop-chromiumand 8/8 onmobile-chromium. They cover Settings language sync, data export, account deletion and the model pickers.Screenshots
Settings at 1280 and 375 px, from the
pr-assets/t16-hide-byokbranch (not for merge):No other page changed.
Follow-ups (not in this PR)
public.api_keysis still writable by any signed-in user for their own rows (authenticated grants plus theapi_keys_allpolicy), even though nothing reads it. The 2026-10-08 security report already proposes dropping it once production row counts are checked. A non-destructive first step is revoking client grants.Lockicon on the Account card suited the old key line better than it suits sign-in and data export. That's T6's file, so I left it..claude/skills/verify-debatelab/features/usage-limits.md:3still says calls on our own key add only OpenRouter's fee.cost.tsanddocs/architecture.mdnow count the full charge.🤖 Generated with Claude Code