Repository navigation
Start a debate on the first Generate instead of asking (MD-10, Adam to decide) - #212
Closed
Programcode wants to merge 1 commit into
Closed
Programcode wants to merge 1 commit into
Programcode wants to merge 1 commit into
Conversation
… choice) With no Current Debate, Generate creates a debate for its motion and says so in a toast, instead of opening "Start a debate with this motion?". The strip offers Use once beside Start debate, so a one-off run is still a choice. A second submit while the debate is being created does nothing, and a failed create falls back to the dialog. Other tools keep the dialog. Adam to confirm. This commit holds the whole change, including tests, recipes, docs and the production canary, so it reverts alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Note 🎁 Summarized by CodeRabbit Free
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Closing: Adam decided to keep the existing first-Generate "Start a debate with this motion?" dialog (MD-10 not shipping). |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adam's design call. Do not merge until Adam decides.
This is MD-10 from the 22 Oct QA report (batch T8). It was split out of #211 so the rest of T8 could ship. It is commit e8fb46d from #211, cherry-picked unchanged onto main 7407139 (#211's squash). #211 reverted it before merging.
What changes: the first Generate no longer stops to ask "Start a debate with this motion?".
Review: this commit was part of #211's two fresh-context Claude Opus review rounds. Round 1's Medium (it could create a debate before the debate list loaded) is fixed here: the create now waits for
hydrated. Round 2 found no Medium or higher.Checks on this branch: typecheck passes and all 584 unit tests pass. Before merging, if Adam approves: sync with main, run the full verify, and run the current-debate, case-generation and model-defaults recipes on desktop and mobile.
Before/after screenshots are in the T8 T3 thread (mcp:fdbfa25d).
🤖 Generated with Claude Code