Repository navigation
Keep Jam out of the full-stack e2e harness - #198
Merged
Merged
Conversation
Jam now starts on the first click (#196), mid-test, and wraps window.fetch. After that the lib-add recipe can no longer read the streamed ai response in Playwright. Serve empty Jam modules from the full-stack page fixture, which the gate and the verify recipes share. The app loader is unchanged.
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 23 seconds. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #196. T7 found that the lib-add recipe fails on desktop and mobile on main: since #196, Jam loads on the first click in the middle of the test, and after that Playwright can't read the streamed
airesponse.Real users are not affected. I checked production (debate.pi-stack.org) with the real Jam scripts loaded by a click:
window.fetchandXMLHttpRequest.prototype.send.ReadableStreamis untouched.text/event-streamresponse with 4 events 500 ms apart reached the page one chunk at a time with Jam (522, 1014, 1515 and 2019 ms) and without it (518, 1017, 1519 and 2020 ms). The request body arrived intact.TransformStreamthat enqueues every chunk as soon as it arrives. It does not buffer.So no rollback was needed, and the loader stays as it is.
Change: the full-stack page fixture (
e2e/full-stack/stack.ts), which both the gate and the verify-debatelab recipes use, now serves empty modules forhttps://js.jam.dev/**, so Jam never starts in those runs. The browser-only specs that cover Jam loading (startup-shell,loading-performance) are unchanged.