Repository navigation
Give the /tools pages a #short-answer section and drop their exemption - #191
Merged
Merged
Conversation
Each free tool page and the /tools hub now opens with a question H2 (#short-answer) and a short, direct answer, in English, Spanish and Hungarian. On the four tool pages that answer also leads the FAQPage JSON-LD, the same way the guide pages do. With every indexed page answering a question, the temporary /tools exemption in scripts/check-site.mjs and its note in docs/operations.md are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 24 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five
/toolspages from #181 each open with a#short-answersection now. The first H2 is a question with a short, direct answer, in English, Spanish and Hungarian. This PR also removes the temporary/toolsexemption from the site check (added in a1232d0, squashed into #156) and its note indocs/operations.md.What changed
ToolPageLayouttakes a requiredshortAnswerprop and renders it under the intro, before the tool. It has to come first because the timer, the calculator and the hub cards contain H2s of their own.src/locales/tools/{en,es,hu}.jsonundershortAnswer. The motion count is interpolated fromPRACTICE_MOTIONS.length, so it stays correct.scripts/check-site.mjsanddocs/operations.mdare back to exempting only/termsand/privacy.Nothing touches SQL, migrations or Edge Functions.
Verification
GitHub Actions is out of minutes, so these are local results on
98fdc379, not CI:npm run verifyexited 0: docs check, lint (eslint, knip, repo rules), typecheck, unit 404/404, collaboration 30/30, edge 394/394, build, service-worker test, smoke e2e 42 passed and 1 flaky. The flaky test,e2e/startup-shell.spec.ts(/appmounting before Jam), passed on retry and doesn't touch/tools.47 HTML files, sitemap and llms.txt resolve; no problems. Every builtdist/tools/**/index.htmlhas<h2 id="short-answer">as its first H2.#short-answeras the first H2, ending in?, with the translated answer and no raw keys. The only console errors came from/_vercel/insightsand/_vercel/speed-insights, which exist only on Vercel's hosting.The H1, intro and article on these pages are still hard-coded English, as they were in #181. Only the short answer and the tool UI change with the language.
🤖 Generated with Claude Code