Skip to content

Keep a running speech when the timer's arrow keys hit either end - #188

Merged
Programcode merged 5 commits into
mainfrom
fix/free-tools-review-followup
Oct 22, 2026
Merged

Programcode merged 5 commits into
mainfrom
fix/free-tools-review-followup

Conversation

@Programcode

@Programcode Programcode commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Two fixes from the Codex review of #181. That review ran on its merged head, 79229bb4, after #181 had already merged.

  • The timer's arrow keys could wipe a running speech. Pressing Left on the first speech, or Right on the last one, reset the clock and paused it. goToSegment clamped the index but always returned a fresh paused speech. The on-screen buttons are disabled at the ends, but the keyboard path wasn't. Asking for the speech already shown now changes nothing. A side effect: clicking the speech button that is already selected no longer resets it, and the Reset button does that.
  • The tools hub promised saved drafts. Only the timer saves anything (the round, in this browser). The calculator text and the flow-sheet fields are lost on navigation, so the hub copy now says only the timer saves.

Verification

All of these are local, on this branch's head 21ab40f3. None is a CI pass: GitHub did not start any Actions job on this PR, citing a billing or spending limit.

  • npm run verify passed end to end: docs check, lint (ESLint, knip, repo rules), typecheck, 405 unit tests in 56 files, 30 collaboration tests, 392 edge tests, the build with prerender and sitemap, test:sw, and the desktop @smoke browser set (43 passed). An earlier run had one SparringVoice.test.tsx test time out at 5 seconds while the box was loaded. That file is untouched here, it passed 12/12 alone, and the full rerun was clean.
  • A new unit test in src/test/free-tools/round-timer.test.ts fails on main and passes with the fix.
  • Real browser on the dev server, with a paused Playwright clock. I started the first PF speech, let it run 30 seconds and pressed Left: still on "Team A constructive", still running, 3:28 left. I moved to the last speech, ran it 20 seconds and pressed Right: still on "Team B final focus", still running, 1:38 left.

The second Codex finding is the copy change. Nothing was dismissed.

🤖 Generated with Claude Code

Left on the first speech or Right on the last reset and paused the clock,
because navigation clamped the index but always started a fresh speech.
Asking for the speech already shown now changes nothing. The tools hub no
longer promises saved drafts: only the timer saves anything.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 15:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between e75ad13 and 388c3c8.

📒 Files selected for processing: 3
  • src/lib/free-tools/round-timer.ts
  • src/pages/tools/ToolsHubPage.tsx
  • src/test/free-tools/round-timer.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing.

Comment @coderabbitai help to get the list of available commands.

@Programcode
Programcode merged commit 979a9bc into main Oct 22, 2026
2 of 8 checks passed
Programcode added a commit that referenced this pull request Oct 22, 2026
#188 corrected the hub intro: the timer saves your round in this
browser, and the calculator and flow sheet save nothing. The hub's
short answer still promised saved rounds and drafts, in all three
languages. It now says the same thing as the intro.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants