Repository navigation
Keep a running speech when the timer's arrow keys hit either end - #188
Merged
Merged
Conversation
Left on the first speech or Right on the last reset and paused the clock, because navigation clamped the index but always started a fresh speech. Asking for the speech already shown now changes nothing. The tools hub no longer promises saved drafts: only the timer saves anything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 10 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
…-followup # Conflicts: # src/pages/tools/ToolsHubPage.tsx
Programcode
added a commit
that referenced
this pull request
Oct 22, 2026
#188 corrected the hub intro: the timer saves your round in this browser, and the calculator and flow sheet save nothing. The hub's short answer still promised saved rounds and drafts, in all three languages. It now says the same thing as the intro. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from the Codex review of #181. That review ran on its merged head,
79229bb4, after #181 had already merged.goToSegmentclamped the index but always returned a fresh paused speech. The on-screen buttons are disabled at the ends, but the keyboard path wasn't. Asking for the speech already shown now changes nothing. A side effect: clicking the speech button that is already selected no longer resets it, and the Reset button does that.Verification
All of these are local, on this branch's head
21ab40f3. None is a CI pass: GitHub did not start any Actions job on this PR, citing a billing or spending limit.npm run verifypassed end to end: docs check, lint (ESLint, knip, repo rules), typecheck, 405 unit tests in 56 files, 30 collaboration tests, 392 edge tests, the build with prerender and sitemap,test:sw, and the desktop@smokebrowser set (43 passed). An earlier run had oneSparringVoice.test.tsxtest time out at 5 seconds while the box was loaded. That file is untouched here, it passed 12/12 alone, and the full rerun was clean.src/test/free-tools/round-timer.test.tsfails onmainand passes with the fix.The second Codex finding is the copy change. Nothing was dismissed.
🤖 Generated with Claude Code