Repository navigation
Fall back to the structured Ask when a failed stream sent only whitespace - #187
Merged
Merged
Conversation
…pace A reply cut off at its cap before any real text fails in ai-stream, but a leading newline already counted as streamed text, so the page kept an empty answer instead of asking the structured endpoint, which retries with a larger cap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 26 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-forward for #182, found by its post-merge Codex review.
Since #182,
ai-streamfails an Ask stream that was cut off at its length cap before any real text arrived. A failed stream should make the Ask page fall back to the structured endpoint, which retries with a larger cap. The page decided whether to fall back by checking whether any delta had arrived, though, so a model that sent"\n\n"and then ran out of tokens left an empty answer and an "interrupted" toast instead.The page now falls back unless the partial answer has text other than whitespace. A partial answer with real text is still kept as before.
Verification
GitHub Actions doesn't run repo-wide right now (account billing), so these ran locally:
src/test/pages/AskStreamFallback.test.tsx(new) checks two cases: a stream that sent only whitespace falls back toaskChat, and a stream that sent real text keeps it. The first case fails againstmain'sAskPage.tsxand passes with this change.src/test/pages/AskAccountSwitch.test.tsxstill passes.🤖 Generated with Claude Code