Repository navigation
Reload once when a deploy leaves a tab holding an old chunk - #175
Merged
Merged
Conversation
A missing script showed Unable to load this page, and the service worker could store an HTML error as if it were that script. The tab now reloads once per path, and HTML is no longer cached for scripts, styles, or assets. Co-authored-by: Gáborjáni-Szabó Ádám <Programcode@users.noreply.github.com>
Co-authored-by: Gáborjáni-Szabó Ádám <Programcode@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 48 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
Programcode
marked this pull request as ready for review
October 22, 2026 12:27
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a deploy, an open tab can request a script the new build no longer has. The app then showed "Unable to load this page." The service worker could also store an HTML response as if it were that script, so the next load kept failing from cache.
The app now listens for Vite's preload error and reloads once per path. A second failure on the same path stays on the error screen, so a missing file cannot refresh the tab forever. The service worker skips caching when a script, style, or
/assets/response is HTML, and the cache version moved from v3 to v4 so an already poisoned cache is dropped on activate.No layout change. The visible behavior is one automatic reload after a stale chunk, then the existing error screen if it still fails.
Verified locally (GitHub Actions is out of minutes, so this is not a CI pass):
npx vitest run src/test/lib/reload-stale-chunk.test.ts src/test/vercel-deployment-config.test.ts(20 passed)npx eslinton the touched TypeScript filesnpm run typecheckNot run:
npm run test:sw(the Playwright offline worker) andnpm run verify.