Repository navigation
Stop offering Pro again when a paid plan hits the daily cap - #173
Merged
Merged
Conversation
The limit dialog always showed Upgrade to Pro at $5 a month, including for someone who already pays and has simply used today's included requests. That case now closes with OK, and the price note stays hidden. Co-authored-by: Gáborjáni-Szabó Ádám <Programcode@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 49 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily-cap dialog always showed "Upgrade to Pro - $5/mo", including for a student who already pays and has simply used today's included requests. The description already says access comes back at midnight UTC. The button contradicted that.
When the signed-in plan is Pro or Legacy Free and the dialog is the daily cap, the primary button is now OK (Entendido / Rendben) and it only closes the dialog. The price note and the upgrade button stay hidden. A trial that has ended still offers Pro.
UI change for the preview: open the daily-cap dialog on a Pro account and confirm it says OK, with no $5/mo button. A free or expired account should still see Upgrade to Pro.
Verified locally (GitHub Actions is out of minutes, so this is not a CI pass):
npx vitest run src/test/components/LimitReachedModal.test.tsx(3 passed)npx eslinton the modal and the testnpm run typechecknpm run docs:checkNot run:
npm run verifyand a browser pass. Page tests mock this modal away, so the new test renders it directly with the subscription hook mocked.