Repository navigation
Clear Ask when you leave while it is still answering - #170
Merged
Merged
Conversation
Leaving the page aborted the request but left the loading flag set, so coming back showed Typing forever and the composer stayed disabled. The partial answer is now kept and the composer is usable again. Co-authored-by: Gáborjáni-Szabó Ádám <Programcode@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 49 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
Programcode
marked this pull request as ready for review
October 22, 2026 12:26
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving Ask in the middle of an answer aborted the request but left the page on "Typing." Coming back showed a chat that was still waiting, with no way for that wait to finish.
I reproduced the path in the Ask account-switch test: start a stream, unmount the page, and the loading flag stayed true. The cleanup only ran
abort, and the in-flight finish step then skipped clearing the spinner because the request id had changed.Leaving the page now clears the spinner. If some of the answer had already arrived, that partial text is saved as a stopped assistant message using the existing "you stopped this answer" line.
No layout change.
Verified locally (GitHub Actions is out of minutes, so this is not a CI pass):
npx vitest run src/test/pages/AskAccountSwitch.test.tsx(2 passed, including the new mid-answer leave case)npx eslintonAskPage.tsxand that testnpm run typecheckNot run:
npm run verifyand a click-through in the browser.