Repository navigation
Report a failed Google Doc update instead of an empty success - #165
Merged
Merged
Conversation
Creating the document and then failing to write its content still returned 200 with success true, so the app opened a blank file. A failed batch update now returns 502 with the document link and a fixed error. Co-authored-by: Gáborjáni-Szabó Ádám <Programcode@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 51 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export could create the Google Doc and then fail to write the body. The function still returned HTTP 200 with
success: true, so the app opened a blank document and treated the export as done.I found the fall-through after
batchUpdateinsupabase/functions/export-gdoc/index.ts. The client already treats any non-OK response as a failure and showserror, so the function now returns 502 with a fixed message andDOCUMENT_UPDATE_FAILEDwhen the content update fails. The empty file still exists in Drive; the response includes its URL, and the app no longer claims success. An update Google accepts still returns the document.No client or layout change.
Verified locally (GitHub Actions is out of minutes, so this is not a CI pass):
deno test supabase/functions/export-gdoc/auth_test.ts(6 passed), including a failed batch update and a successful oneNot run: a real Google Docs export. That needs a Google token and was not attempted.