Repository navigation
Cancel a Stripe subscription that completes after the account is deleted - #162
Merged
Merged
Conversation
Deleting an account cancels the billing it can see. A Checkout that finishes in that window still created a Stripe subscription, then the webhook failed forever because the user no longer existed, so Stripe kept charging. The webhook now cancels that subscription and acknowledges the event. A lookup that fails for any other reason still retries. Co-authored-by: Gáborjáni-Szabó Ádám <Programcode@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 52 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
Programcode
marked this pull request as ready for review
October 22, 2026 12:24
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting an account cancels the subscriptions it can see. If Checkout finishes in that same moment, Stripe still creates a subscription, then the webhook tries to save it for a user who no longer exists. That save fails, Stripe retries forever, and the charge keeps going with nobody left in the app to cancel it.
When Checkout completes, the webhook now checks that the account still exists. If it was deleted, the webhook cancels that Stripe subscription and acknowledges the event so Stripe stops retrying. If the account lookup fails for any other reason, the webhook still returns an error and Stripe retries, so a paying user is not canceled by a blip.
Verified locally with the account-lookup tests and eslint on the webhook files. GitHub Actions is not running because of the repo billing limit, so this is a local pass, not a CI pass. This does not deploy the Edge Function or change any live data.