Repository navigation
Put a saved case back when deleting it fails - #159
Merged
Merged
Conversation
History removed the case locally before the server delete, and a failed delete never threw, so the toast said it was deleted while the row stayed. The delete now waits for the server and puts the case back when that fails. Co-authored-by: Gáborjáni-Szabó Ádám <Programcode@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 51 minutes. View limit details
Note 🎁 Summarized by CodeRabbit Free
Comment |
Programcode
marked this pull request as ready for review
October 22, 2026 12:24
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a saved case on History took it off the list immediately and never checked whether the server delete worked. The promise still resolved, so the toast said the case was deleted. After a refresh it was back.
The delete now confirms the signed-in user, checks the server result, and puts the case back on the list when that fails. History already shows the error toast when the promise rejects.
Verified locally with
tsc --noEmit -p tsconfig.app.jsonand the new Vitest cases. GitHub Actions is not running because of the repo billing limit, so this is a local pass, not a CI pass.