Repository navigation
Native iOS app: Brainstorm and Factoids - #131
Conversation
The app sends Brainstorm and Factoids the way the website does, so the pure parts of brainstorm and factoids in src/lib/ai/client.ts now live in packages/core: the brainstorm response transform, the factoids request defaults and the verified-factoid selection. The website imports them back and behaves as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both tools work as on the website: a native form with its fields and defaults, the website's progress messages while the request runs, and the result as a document in 4a's style with Discuss and Export pinned and Undo auto-saved sources and Delete in the "..." menu. Brainstorm goes through the motion gate and saves to brainstorms with the chosen side. Factoids follows the Current Debate, as the website's page does, and saves with side neutral. Each factoid can be kept in the debate's Factoids folder, and a search suggestion reopens the form with that query. The PDFs use the website's file names and sections, and "Copy as text" follows its Word export. Both tabs and saved rows open the real screens now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The screenshot script now shoots both tools' forms, their progress, the documents open and collapsed, and the Export menu, from a fixed brainstorm and fixed factoids inside the page. It renders each PDF's HTML and writes the copied text next to the screenshots. Nothing calls a model or saves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
Brings in #129. Conflicts kept both sides: the Debate tab and Prepare import the shared OneOffNotice next to prepareToolHref, the screenshot script shoots Brainstorm and Factoids and then the one-off tools, and the app guide keeps the Brainstorm and Factoids paragraph beside #129's one-off text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both forms show it through WorkingIn since #129. The screenshot script now opens each from Prepare in one-off mode and waits for the notice, and the app guide names them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A brainstorm whose nextSteps held an object passed the transform, was saved, and then crashed its document and the export. The shared transform now keeps only text in its string lists, and the app reads every brainstorm, fresh or saved, through the transform and BrainstormOutputSchema. Saved factoids rows go through FactoidsOutputSchema too, so a broken old row shows the incomplete notice instead of crashing. Each factoid's save button now tells VoiceOver which claim it saves, with the website's factoidsResults.saveClaimToLibrary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex review (gpt-6.1-sol)
Local checks at a5705dc. GitHub Actions starts no jobs because of billing, so these ran locally: Merging into 🤖 Generated with Claude Code |
Brings in feat/native-ios after #129 and #131's fixes. sheet.tsx, keep-if-same.ts and one-off-notice.tsx were the same on both sides, so the Flowchart now uses the shared files. Conflicts: apps/mobile/AGENTS.md keeps the Flowchart entry and the base's one-off wording, with the Flowchart added to where OneOffNotice shows; the screenshot script runs both the Flowchart and the one-off tool shots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>


Brainstorm and Factoids in the app, built from PR #130's document components and helpers. Targets
feat/native-ios.Brainstorm
brainstormswith the motion as the title and the chosen side.Factoids
neutralwith the claim as the title.Factoidsfolder, as the website's bookmark does.Shared with #130
BrainstormResults.pdf,ResearchFactoids.pdf) and its sections, with model text escaped.@debatelab/core. The website imports them back and behaves as before.Different from the brief, on purpose
neutraland the website's side rule hides neutral work, so they open from the Prepare list.Checks. These ran locally on Node 22, because GitHub Actions starts no jobs on this account (billing).
npm run verifyexits 0: 289 Vitest tests, 333 Deno tests and 30 Chromium smoke tests.Live on the staging seed Pro account. One Brainstorm took 47.5 s and one Factoids 45.5 s. Both saved, opened, exported to PDF HTML and copied text. The factoid bookmark was saved. Both results were deleted through the app's menu, along with the 11 sources the run created. The counts afterwards match the counts before.
Not proven. The live run ran on the commit just before #130's last fix, which only added the cancel signal; that last step is covered by the typecheck. A real PDF file, the native menus and the in-app browser on a phone are for Adam's milestone test.
🤖 Generated with Claude Code