Repository navigation
Translate the 88 missing literal i18n keys and guard them with a test - #109
Conversation
Co-Authored-By: Codex <noreply@openai.com>
The Hungarian plural assertion re-tested i18next; the key scan already requires _one and _other forms. docs/testing.md still described the i18n.test.ts removed in b9ef0b3. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (10)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
|
@coderabbitai review |
|
|
Local results at 6d72dcc. GitHub Actions refused every job ("recent account payments have failed or your spending limit needs to be increased"), so these are local passes, not CI passes.
Hungarian Flowchart before and after: the edge-type picker and "Auto layout" are now translated. The strength chips ("strong", "moderate", "weak") stay English because they render a raw value, not a literal key, so the scan can't see them. That predates this PR and is left for a follow-up. |


Spanish and Hungarian users no longer see English in 88 places where a
t()key existed in no catalog: toasts, confirmation dialogs, Library folder actions, Flowchart controls and the Google Drive dialog. Implements plans/2026-10-02-missing-translation-keys.md.What changed
en.json,es.json,hu.json: the 88 missing literal keys, 40_one/_otherforms for calls that passcount, and 2 new keys.ask.saveFailedDesc, the chat save message. They now useask.sourceSaveFailedDescandgenerate.saveFailedDesc.src/test/i18n-keys.test.ts: parsessrc/with the TypeScript compiler. It fails when a literal key passed tot()ori18n.t()is missing fromen.json, or when a call that passescountlacks its plural forms. It failed onmain's catalogs before this change.src/test/i18n.test.tsrestored as a parity check only: it requires the same keys in all three catalogs, which is what forces Spanish and Hungarian to get every new key. The earlier version was removed in b9ef0b3, anddocs/testing.mdstill described it; the doc now describes both tests.The translations follow existing catalog terms (Spanish "Interrogatorio", Hungarian "Eset" and "Keresztkérdezés"). No native speaker has reviewed them.
Verification
Local only; Actions is blocked by billing. At 6d72dcc,
npm run verifypassed, the Hungarian browser contract passed on desktop and mobile Chromium, and the key scan fails againstmain's catalogs. A Codex review found nothing. Before and after screenshots and the exact counts are in the comment below.🤖 Generated with Claude Code