Skip to content

Translate the 88 missing literal i18n keys and guard them with a test - #109

Merged
Programcode merged 2 commits into
mainfrom
chore/i18n-missing-keys
Oct 6, 2026
Merged

Programcode merged 2 commits into
mainfrom
chore/i18n-missing-keys

Conversation

@Programcode

@Programcode Programcode commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Spanish and Hungarian users no longer see English in 88 places where a t() key existed in no catalog: toasts, confirmation dialogs, Library folder actions, Flowchart controls and the Google Drive dialog. Implements plans/2026-10-02-missing-translation-keys.md.

What changed

  • 130 entries in each of en.json, es.json, hu.json: the 88 missing literal keys, 40 _one/_other forms for calls that pass count, and 2 new keys.
  • The 2 new keys: source and case save failures used ask.saveFailedDesc, the chat save message. They now use ask.sourceSaveFailedDesc and generate.saveFailedDesc.
  • New src/test/i18n-keys.test.ts: parses src/ with the TypeScript compiler. It fails when a literal key passed to t() or i18n.t() is missing from en.json, or when a call that passes count lacks its plural forms. It failed on main's catalogs before this change.
  • src/test/i18n.test.ts restored as a parity check only: it requires the same keys in all three catalogs, which is what forces Spanish and Hungarian to get every new key. The earlier version was removed in b9ef0b3, and docs/testing.md still described it; the doc now describes both tests.
  • Inline English fallbacks stay, so a dynamic key that misses still renders English rather than a raw key.

The translations follow existing catalog terms (Spanish "Interrogatorio", Hungarian "Eset" and "Keresztkérdezés"). No native speaker has reviewed them.

Verification

Local only; Actions is blocked by billing. At 6d72dcc, npm run verify passed, the Hungarian browser contract passed on desktop and mobile Chromium, and the key scan fails against main's catalogs. A Codex review found nothing. Before and after screenshots and the exact counts are in the comment below.

🤖 Generated with Claude Code

Programcode and others added 2 commits October 6, 2026 07:49
Co-Authored-By: Codex <noreply@openai.com>
The Hungarian plural assertion re-tested i18next; the key scan already
requires _one and _other forms. docs/testing.md still described the
i18n.test.ts removed in b9ef0b3.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 07:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Oct 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
debate-navigator Ready Ready Preview Oct 6, 2026 7:59am UTC
debatelab-staging Ready Ready Preview Oct 6, 2026 7:59am UTC

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Free
  • Run ID: d8d7aca6-4f0c-4ca7-ba2e-c4e3b352e286
📥 Commits

Reviewing files that changed from the base of the PR and between 292e7fd and 6d72dcc.

📒 Files selected for processing (10)
  • docs/testing.md
  • plans/2026-10-02-missing-translation-keys.md
  • plans/README.md
  • src/locales/en.json
  • src/locales/es.json
  • src/locales/hu.json
  • src/pages/AskPage.tsx
  • src/pages/GeneratePage.tsx
  • src/test/i18n-keys.test.ts
  • src/test/i18n.test.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing.

Comment @coderabbitai help to get the list of available commands.

@Programcode

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Programcode

Copy link
Copy Markdown
Owner Author

Local results at 6d72dcc. GitHub Actions refused every job ("recent account payments have failed or your spending limit needs to be increased"), so these are local passes, not CI passes.

  • npm run verify exited 0: docs, lint, typecheck, 27 unit files (273 tests), collaboration (30 tests), 318 Edge tests, build, service-worker smoke, 29 Playwright smoke tests.
  • e2e/hungarian-parity.spec.ts on desktop and mobile Chromium: 6 passed.
  • src/test/i18n-keys.test.ts fails against main's en.json and passes here.
  • Codex review (gpt-6.1-sol, high) of 6d72dcc: no findings. It checked all 130 additions per catalog for meaning, placeholders, nesting and plural forms, and ran 390 i18next rendering checks.

Hungarian Flowchart before and after: the edge-type picker and "Auto layout" are now translated. The strength chips ("strong", "moderate", "weak") stay English because they render a raw value, not a literal key, so the scan can't see them. That predates this PR and is left for a follow-up.

Hungarian Flowchart on main

Hungarian Flowchart on this branch

@Programcode
Programcode merged commit 3659bd1 into main Oct 6, 2026
6 of 9 checks passed
@Programcode
Programcode deleted the chore/i18n-missing-keys branch October 6, 2026 08:09

This branch was successfully deployed

2 active deployments
Preview – debate-navigator — 6d72dcc0 Deployed Oct 6, 2026 by vercel[bot]
Preview – debatelab-staging — 6d72dcc0 Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants