Repository navigation
fix(layout): keep tool results columns inside the page - #101
Conversation
A live Generate run quoted a 135-character URL in its evidence and the results column grew 66px past its container, widening the page by 2px. A 1fr grid track never shrinks below the min-content width of its contents, so one unbreakable word sets the column width. Use minmax(0,1fr) for the results track on Generate, Attack, Brainstorm, Factoids, Ask and the route skeleton. The URL now wraps inside its card. The new spec replays that response and fails without the fix. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The voice-rounds and account-data recipes call these functions, but `up` printed READY without checking that they answer. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (8)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughResults grids now use flexible columns with a zero minimum. An end-to-end test checks generated content and overflow. Startup readiness checks also include the voice and account Edge Functions. ChangesResults Grid Overflow
Startup Readiness Checks
Estimated code review effort: 2 (Simple) | ~10 minutes Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
What broke
On #98's live-e2e run, a live model answer quoted a 135-character URL in its evidence, and the Generate page got 2px wider than the viewport. The results column measured 746px against a 680px track.
The cause is that a
1frgrid track never shrinks below the min-content width of what's inside it, so one long unbreakable word decides how wide the column is.Fix
minmax(0,1fr)on Generate, Attack, Brainstorm, Factoids, Ask and the matching route skeleton. Text already wraps withoverflow-wrap, so the URL now breaks inside its card.verify.sh upnow also waits for thevoiceandaccountEdge Functions before it prints READY, since the voice-rounds and account-data recipes call them.Verification
e2e/results-overflow.spec.tsreplays the live response. It fails without the fix, with the column 62px past its container, and passes with it on desktop-chromium and mobile-chromium.npm run lintandnpm run typecheckpass.CI did not run
GitHub refused to start the Actions jobs ("recent account payments have failed or your spending limit needs to be increased"). They failed in 1 to 2 seconds with no logs. These are local results at
2f95fd8, not a CI pass:npm run verifyexit 0: 251 browser tests passed, 6 skipped, 1 flaky.navigation-performance.spec.ts:118(route fallback). Its first attempt found the skeleton, then lost a timing race under a load average of about 22. Rerun on its own with--repeat-each 5 --retries 0, it passed 5 of 5.npm run verifystopped on a 5-second unit-test timeout inSparringPage.test.tsxunder the same load. That file passes 3 of 3 alone on this branch and passes onmain.verify.sh up(fake provider) reached READY, so the new wait forvoiceandaccountholds.drive recipes/case-generationpassed 7/7 on desktop-chromium and 7/7 on mobile-chromium.🤖 Generated with Claude Code
Summary by CodeRabbit