Repository navigation
Conversation
Diff two canonical, product-scaling, page-load, or cold-start captures and print headline metric changes without mixing suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
compare/so two retained JSON captures from the same suite can be placed next to each other. Headline cells (render P50 and payload bytes, HTTP capacity, cold-start first response) print as Markdown or JSON. Captures from different suites are rejected, and a cell that exists on only one side is listed as added or removed rather than filled in.Why
The published numbers are dated records from one machine. This repository already keeps more than one canonical archive, and a later recapture is supposed to be checked against the current page before it replaces it. Until now that check meant reading two tables by eye. The protocol also forbids joining values across suites; this command enforces that by refusing a mixed pair.
How to try it
--jsonwrites the structured comparison.--suite canonical(orproduct-scaling,page-load,cold-start) fails if the files are a different suite.Notes
node --test compare/compare.test.mjs.BENCHMARK_PROTOCOL.mdpoint atcompare/.package.jsonor the HTTP/renderer source lists.Demo