Skip to content

pc 26.2: fix enchantment entity predicates in loginPacket.json - #1322

Open
DallasCarraher wants to merge 1 commit into
PrismarineJS:pc_26_2from
DallasCarraher:pc-26.2-enchant-predicates
Open

DallasCarraher wants to merge 1 commit into
PrismarineJS:pc_26_2from
DallasCarraher:pc-26.2-enchant-predicates

Conversation

@DallasCarraher

Copy link
Copy Markdown

Summary

  • Follow-up to Add Minecraft PC 26.2 data (protocol 776) #1298 addressing VasilisDragon's post-merge comment.
  • In data/pc/26.2/loginPacket.json, renames the entity predicate key type to minecraft:entity_type for bane_of_arthropods, channeling, impaling, looting, power, punch and smite (9 lines).

Not covered

  • lunge was also listed as rejected by vanilla 26.2's Enchantment.DIRECT_CODEC, but its predicates use type_specific/flags/vehicle rather than the plain type key, so I don't know what is wrong there and left it unchanged.
  • The rename follows the description in the comment and has not been checked against vanilla's codec. @VasilisDragon could you confirm, and say what lunge needs? Regenerating the registry from 26.2 sources would also work.

Test plan

  • test.js and audit_versions.js pass (915 passing)
  • Validate all 43 enchantments against vanilla 26.2's codec

🤖 Generated with Claude Code

Fixes stale predicate encoding in loginPacket.json for bane_of_arthropods,
channeling, impaling, looting, power, punch and smite, per post-merge
review on PrismarineJS#1298.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant