pc 26.2: fix enchantment entity predicates in loginPacket.json - #1322
Open
DallasCarraher wants to merge 1 commit into
Open
DallasCarraher wants to merge 1 commit into
DallasCarraher wants to merge 1 commit into
Conversation
Fixes stale predicate encoding in loginPacket.json for bane_of_arthropods, channeling, impaling, looting, power, punch and smite, per post-merge review on PrismarineJS#1298. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data/pc/26.2/loginPacket.json, renames the entity predicate keytypetominecraft:entity_typeforbane_of_arthropods,channeling,impaling,looting,power,punchandsmite(9 lines).Not covered
lungewas also listed as rejected by vanilla 26.2'sEnchantment.DIRECT_CODEC, but its predicates usetype_specific/flags/vehiclerather than the plaintypekey, so I don't know what is wrong there and left it unchanged.lungeneeds? Regenerating the registry from 26.2 sources would also work.Test plan
test.jsandaudit_versions.jspass (915 passing)🤖 Generated with Claude Code