Fix/pc shears speed - #1310
Merged
extremeheat merged 2 commits intoSep 18, 2026
Merged
Fix/pc shears speed#1310
Conversation
Copper tools were generated at speed 1.0 because the generator's speed table had no copper entry; vanilla is 5.0. Regenerated with PrismarineJS/minecraft-data-generator#87; 1.21.10 shares pc/1.21.9.
From 1.21.5 the generator overwrote its shears special cases with the 1.0 default; vanilla is 15 on leaves and 5 on wool. Regenerated with PrismarineJS/minecraft-data-generator#88; 1.21.10 shares pc/1.21.9.
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From 1.21.5,
materials.jsonlists shears at speed 1.0 on theleavestables and onwool(vanillaShearsItem: 15 and 5) - the generator's tool-component walk overwrote its own special cases (fixed in PrismarineJS/minecraft-data-generator#88).prismarine-blockdigTime()therefore reports wool with shears at 1200 ms instead of 250, and leaves at 300 ms instead of instant.Regenerated
materials.jsonfor 1.21.5, 1.21.6, 1.21.8, 1.21.9 (also 1.21.10), 1.21.11 and 26.1: exactly four entries change per file, all the shears id (leaves,leaves;mineable/hoe,leaves;mineable/axe;mineable/hoe1.0 -> 15.0;wool1.0 -> 5.0). Live on vanilla 26.1 with mineflayer 4.39.0: wool with shears 251 ms (was 1211), leaves instant, cobweb and vine unchanged at their correct values.Stacked on #1309