fix recipe serializer IDs in 1.20.5 and 1.21.1 - #1291
Open
VasilisDragon wants to merge 3 commits into
Open
VasilisDragon wants to merge 3 commits into
VasilisDragon wants to merge 3 commits into
Conversation
extremeheat
reviewed
Sep 11, 2026
VasilisDragon
marked this pull request as ready for review
September 12, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #1286.
crafting_special_banneraddpatternisn't registered in either version; adding it shifted the existing IDs, so a smelting test packet decoded as repairitem.restores the registry order and removes the stale switch case.
checked against the official client registries and 50 synthetic recipe fixtures with the compiled codec. the local full data suite hit the existing 40s timing assertion on both master and this branch.