Skip to content

Add generated enchantment applicability and rarity data - #1290

Open
Pix3lPirat3 wants to merge 2 commits into
PrismarineJS:masterfrom
Pix3lPirat3:feat/enchantment-supported-items
Open

Pix3lPirat3 wants to merge 2 commits into
PrismarineJS:masterfrom
Pix3lPirat3:feat/enchantment-supported-items

Conversation

@Pix3lPirat3

@Pix3lPirat3 Pix3lPirat3 commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Define optional supportedItems and rarity fields and permit native 1.14 weights. Regenerate four existing enchantment files without changing their existing fields or data paths, and add schema regression tests.

Add optional supportedItems and rarity fields to the enchantment schema, and allow the native 1.14 selection weight of 30.

Replace the complete 1.17, 1.19, 1.19.2 and 1.20 enchantment files with untouched generator output. These are additive updates: existing field values and all dataPaths mappings remain unchanged. The new data lets consumers distinguish exceptions such as Sharpness on axes without also allowing Knockback.

Validation: upstream lint and data tests pass (1,864 passing, one pending).
Each affected version was checked against native server generation: 1.17, 1.17.1, 1.18, 1.18.1, 1.18.2, 1.19, 1.19.2, 1.20 and 1.20.1. Their shared files match complete generated output, with 396,860 native acceptance comparisons and consumer checks using the actual imported data.

The files come from the companion generator change. No generated JSON fields were manually corrected. Historical data-path expansion is deliberately not included: it requires separate validation of every release sharing those paths.

Related PRs:

Define optional supportedItems and rarity fields and permit native 1.14 weights.
Regenerate four existing enchantment files without changing their existing fields or data paths, and add schema regression tests.
Comment thread tools/js/test/enchantment_support.js Outdated

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

The additive data change looks ready from this review of 1a1f869. Existing enchantment fields and data paths are unchanged, and every supportedItems name resolves in each of the nine releases sharing the changed files. The shared 1.17 file exactly matches generator #83’s native 1.18 CI artifact; 54 applicability cases also pass through the actual item #187 candidate across those nine releases. The test file extremeheat requested removing is gone. Locally, all 1,860 semantic/schema tests passed; the suite command failed only its global 40-second timing guard under concurrent load (78 seconds). I did not independently regenerate all four files.

Skills used: prismarine-protocol-data-review checked generated-file provenance, schema compatibility and all shared version paths; prismarine-item-inventory-review exercised actual downstream anvil applicability; prismarine-review verified the requested test removal and reported validation limits.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants