Conversation
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
Reviewed at the maintainer's request. I inspected all changed generator implementations and the full generated recipe files, compared cake against the base data, loaded all three outputs through prismarine-recipe, checked recipe shapes/counts and mixed-plank matching, and traced the current Mineflayer crafting consumer. The inline finding concerns lost crafting remainders. I did not run the Java generator or a live crafting server.
| "id": 354, | ||
| "metadata": 0 | ||
| "metadata": 0, |
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
Please preserve cake's outShape when regenerating this entry (also affected in 1.10 and 1.11). The previous data has [325, 325, 325] in its top output row; the new record loses all three returned empty buckets. I loaded each new file through prismarine-recipe and confirmed cake now has outShape === null. Mineflayer's craft.js then takes updateOutShape()'s early branch, clearing the local grid instead of collecting the bucket slots. Fixing the generator's remainder extraction in minecraft-data-generator#81 and regenerating these entries would preserve that behavior; please add a cake remainder check.
Replaces
data/pc/1.10,1.11and1.12recipes.json(used by 1.10 through 1.12.2) with output from PrismarineJS/minecraft-data-generator#81, which enumerates the server's recipe registry. Closes #182.Defects in the previous wiki-extracted files that this removes:
{"id": 5, "metadata": 5}), so mineflayer could not craft them from other planks.Encoding follows
doc/recipes.md: a bare id is an ingredient that accepts any metadata (vanilla wildcard damage, or a 1.12 alternatives list covering every variant of the item),{id, metadata}otherwise. prismarine-recipe reads a bare id asmetadata: nulland mineflayer then accepts any variant, so no consumer change is needed. Mixed plank types in one grid are valid in vanilla and are accepted with this encoding.The pc 1.12 output equals a direct conversion of the 432 recipe JSON files in the 1.12.2 client jar. The audit test no longer exempts pc 1.10 from the diamond pickaxe check.