You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A client that keeps writing the numeric id gets SizeOf error for undefined : 0 is not in the mappings value and the packet is never sent, so on 26.1 mineflayer currently cannot respawn or right-click an entity at all. These two features let it pick the right shape the same way entityActionUsesStringMapper does.
Checked against every pc protocol.json in this repo: client_command.actionId and use_entity.hand are mappers on 26.1 only.
PrismarineJS/mineflayer#4076 reads the declared form straight out of protocol.json (lib/protocol_enum.js), so it handles client_command.actionId on any version without a feature flag, and these two features are not needed for it.
The useEntityHandIsString half also cannot land together with #1278, which takes use_entity.hand back to a plain varint: whichever of the two merges second makes the other wrong. #1278 + #4076 covers both fields — #1278 for use_entity.hand, which #4076 does not touch, and #4076 for client_command.actionId.
#1278 takes the opposite approach for the same field: it drops 26.1's use_entity.hand mapper instead of describing it. Only one of the two should land; this one also covers client_command.actionId, which #1278 leaves mapped.
PrismarineJS/mineflayer#4077 now reads the shape out of the schema instead of asking for a feature, so it is correct whether 26.1 keeps these mappers or #1278 removes them. That leaves this PR without a consumer; closing in favour of settling the data question on #1278.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
26.1's protocol maps two more serverbound action ids to strings, the way
entity_actionalready does since 1.21.6:A client that keeps writing the numeric id gets
SizeOf error for undefined : 0 is not in the mappings valueand the packet is never sent, so on 26.1 mineflayer currently cannot respawn or right-click an entity at all. These two features let it pick the right shape the same wayentityActionUsesStringMapperdoes.Checked against every
pcprotocol.json in this repo:client_command.actionIdanduse_entity.handare mappers on 26.1 only.Data only, no code changes. Consumed by PrismarineJS/mineflayer#4077.