Align Bedrock 1.21.x block ranges with runtime state palettes - #1276
Merged
extremeheat merged 1 commit intoSep 16, 2026
Merged
extremeheat merged 1 commit into
extremeheat merged 1 commit into
Conversation
- add matching `blocks.json` tables for Bedrock 1.21.20, 1.21.30, and 1.21.50; - point those releases at their matching block tables; - validate complete, non-overlapping state ranges, in-range defaults, and matching block names. The affected versions had distinct `blockStates.json` palettes but reused incompatible `blocks.json` tables. This caused state IDs such as `defaultState` to resolve to the wrong block. The tables use the same pinned PMMP BedrockData palettes validated by the retained official-BDS probes. Fixes PrismarineJS#1156. ## Tests - mapping invariant: 30 unique block/state pairs passing - full minecraft-data suite: 1,896 passing, 1 expected pending - BDS 1.21.20, 1.21.30, and 1.21.50 world/block probes passing - dependency-integrated BDS world/block matrix: 51 passing, 0 failing, 2 unavailable
extremeheat
approved these changes
Sep 9, 2026
extremeheat
reviewed
Sep 9, 2026
| @@ -0,0 +1,44 @@ | |||
| /* eslint-env mocha */ | |||
Member
There was a problem hiding this comment.
Wonder if we could enforce this at a schema level--define some items as unique like in SQL that we can catch generically via some tests. Would help catch this kind of error more broadly for rest of the data
Member
|
Merging to make way for #1297 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocks.jsontables for Bedrock 1.21.20, 1.21.30, and 1.21.50;The affected versions had distinct
blockStates.jsonpalettes but reused incompatibleblocks.jsontables. This caused state IDs such asdefaultStateto resolve to the wrong block. The tables use the same pinned PMMP BedrockData palettes validated by the retained official-BDS probes.Fixes #1156.
Tests