Skip to content

test: add data sanity checks; fix recipes referencing missing item ids (1.8-1.12) - #1242

Open
AnonymoDGH wants to merge 1 commit into
PrismarineJS:masterfrom
AnonymoDGH:fix/mcd-461
Open

AnonymoDGH wants to merge 1 commit into
PrismarineJS:masterfrom
AnonymoDGH:fix/mcd-461

Conversation

@AnonymoDGH

Copy link
Copy Markdown
Contributor

Fixes #461

Adds an audit_sanity.js test with two checks:

  • All PC recipe keys and recipe result ids must exist in items.json
  • block.defaultState must be between minStateId and maxStateId

The new test uncovered real data bugs, fixed here:

  • recipe key 75 (redstone_torch) existed under the wrong id in 1.8-1.12 → moved to key 76 with result id 76
  • recipe key 426 (end_crystal) existed in 1.8 where end_crystal doesn't exist → removed
  • recipe key 452 (iron_nugget) existed in 1.11 where iron_nugget doesn't exist → removed

Verified: 254 tests pass with the new checks; all recipe keys/results now reference existing item ids.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add some more sanity checks in tests

1 participant