Skip to content

fix(scans): retry rejected passwords before continuing setup - #21

Merged
mstrhakr merged 1 commit into
mainfrom
fix/retry-rejected-passwords
Oct 16, 2026
Merged

mstrhakr merged 1 commit into
mainfrom
fix/retry-rejected-passwords

Conversation

@mstrhakr

@mstrhakr mstrhakr commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Pause on InvalidPassword / legacy error 2245 instead of continuing and skipping account-dependent work.
  • Offer manual password replacement, Generate, Retry, or Cancel setup; resume remaining selected steps only after account setup succeeds.
  • Preserve setup choices and copy only the accepted password; cancel stops remaining work and keeps copying disabled.
  • Add regression coverage, update the README, and add AGENTS.md requiring docs upkeep and protected-main branch/PR workflow.

Documentation

Companion docs PR: Printmaster-Org/docs.printmaster.work#10
Docs commit: Printmaster-Org/docs.printmaster.work@8d2db26

Validation

  • PowerShell 7: 52 scans utility Pester tests passed (including dialog event handlers, repeated retries, legacy error 2245, cancellation, and dependent-step gating).
  • Docs: 33 tests passed; pinned Hugo 0.150.1 build passed; generated site links/assets/anchors validated across 105 HTML pages and 103 search entries.
  • git diff --check passed.
  • Windows PowerShell 5.1 validation blocked by local script-signing policy; real machine setup still needs disposable-VM validation.

No release or deployment is included.

Pause setup when Windows rejects a scan-account password and offer manual
replacement, generation, retry, or cancellation before remaining steps.
Cover retries and cancellation with mocked regression tests, update the
README, and require canonical docs upkeep and branch-based PR changes.

Docs: Printmaster-Org/docs.printmaster.work (docs/scans-password-retry)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mstrhakr
mstrhakr force-pushed the fix/retry-rejected-passwords branch from e7dcc7a to e924a0a Compare October 16, 2026 17:03
@mstrhakr
mstrhakr merged commit 3b98898 into main Oct 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant