Skip to content

fix(setup): exit gracefully when initial setup is canceled - #19

Merged
mstrhakr merged 1 commit into
mainfrom
fix/graceful-setup-cancellation
Oct 16, 2026
Merged

mstrhakr merged 1 commit into
mainfrom
fix/graceful-setup-cancellation

Conversation

@mstrhakr

Copy link
Copy Markdown
Collaborator

Summary

Treat dismissing the initial setup dialog as normal cancellation rather than a startup failure.

  • Return exit code 0 instead of 1 when Cancel or window close dismisses the setup dialog.
  • Keep genuine failure handling and the loader's nonzero-exit checks unchanged.
  • Add subprocess regression coverage for both false/null dialog results, asserting a quiet successful exit before setup continues.
  • Document cancellation behavior in the README.

Validation

  • Rebased onto the latest origin/main (already up to date).
  • PowerShell 7: all 47 utility Pester tests passed after rebase.
  • Regression cases execute only the extracted dialog-decision block, not machine configuration.
  • Diff whitespace checks passed; working tree is clean.
  • Windows PowerShell 5.1 remains covered by repository CI; local machine policy prevents unsigned script execution in that runtime.

Release

This changes src/scans.ps1, the versioned Windows utility. Publish a new Scans patch release after merge to deliver the fix through the stable loader. A site-only refresh does not update existing release assets.

Return exit code zero when Cancel or window close dismisses the initial setup dialog so the verified loader does not report an expected cancellation as a startup failure. Add subprocess regression coverage for both dismissal results and document cancellation behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mstrhakr
mstrhakr merged commit 8970fe3 into main Oct 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant