Repository navigation
fix: detect HashSet capacity constructor capabilities - #44
Merged
Merged
Conversation
Probe exact accessible capacity and capacity-plus-comparer signatures independently and preserve portable set construction. Add capability, runtime, package, sample, and documentation coverage. Fixes #30. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30.
HashSet<T>(int)andHashSet<T>(int, IEqualityComparer<T>)constructor signatures independently through consumer Roslyn symbols.Test-first evidence
63885e1af353b45f85c28fdf2306c06409cd92bb: 15 failures, 21 controls, zero skips.Local validation
6351ba8103ad2c867c789eeb3cdca39eb90700b0; the fetched commit was verified and aligned locally.Local environment limits
Trimming and Native AOT fail at ILLink's ComputeManagedAssemblies task-host creation with MSB4216 / Unix-domain SocketException (13), before publish behavior is established. PowerShell and clang are absent; 49 PowerShell-dependent tests were not run locally. No assertions, warning checks, dependencies, prerequisites, credentials, or security settings were weakened.
The fresh cloud workspace restored the previously authorized official Microsoft SDK 10.0.401 and runtimes 8.0.31/9.0.20; runtime 10.0.12 is included. Caches and temporary files are task-local.
CI and review
Exact-head CI run 37935404203 succeeded for
542c24cb886aeae7c33fd2bc34f045e4bb277a35.This PR remains draft for human review and has no merge conflict. No merge, release, tag, NuGet publication, or workflow dispatch was performed.
Dictionary comparer issue #31 and the previously documented nullable-intermediate enum runtime defect remain outside this scope.
Prepared with OpenAI Codex.