Repository navigation
feat(orchestrator): evict the engine group whose weight checksums lose the majority vote - #4034
Closed
faresobeid wants to merge 5 commits into
Closed
faresobeid wants to merge 5 commits into
faresobeid wants to merge 5 commits into
Conversation
# Conflicts: # src/prime_rl/inference/dynamo.py # src/prime_rl/inference/vllm/server.py # src/prime_rl/orchestrator/clients.py # src/prime_rl/transports/weights/nccl.py # tests/unit/orchestrator/test_clients.py
…e the majority vote
Base automatically changed from
feat/engine-groups
to
feat/slurm-engine-steps
October 12, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4033 (engine groups), with #4000 (weight checksums) merged in. Review only the top commit (
git diff 537db777b...feat/checksum-evict).#4000 detects engines whose weights differ after an update, but it can only warn or fail the run. With engine eviction (#3971) the bad engine can instead leave and reload.
What
[weight_broadcast.checksum] evict_mismatched = true(off by default):fail_on_mismatch, as before.find_checksum_outliersholds the vote logic and has a unit test.Checks
pytest tests/unit/orchestrator tests/unit/test_configs.py tests/unit/inference -m "not gpu": 358 passed. ruff is clean.tp0-pp0. A validation-only patch, not in this PR, adds 1.0 to one element ofembed_tokenson engine 8103 when its checksums are computed.Weight checksums of policy v52 mismatch for 1 tensors: engine1/tp0-pp0/model.embed_tokens.weight != engine0, thenEvicted inference engines …:8102, …:8103 (weight checksums of policy v52 differ from the majority …).rejoined at policy v57, all 4 engines in the router at v57.