Splatoon splatfest ranking functions and improve matchmake reliability - #22
Open
RusticMaple wants to merge 7 commits into
Open
Splatoon splatfest ranking functions and improve matchmake reliability#22RusticMaple wants to merge 7 commits into
RusticMaple wants to merge 7 commits into
Conversation
ashquarky
requested changes
Jul 29, 2026
ashquarky
left a comment
ashquarky
left a comment
Member
There was a problem hiding this comment.
Good stuff overall, just a couple notes on the DB handling since this game has a lot of custom tools people throw at it
Author
|
i adjusted the commit just now, i wasnt able to find the code which is responsible for deserializing the |
DaniElectra
reviewed
Jul 31, 2026
Author
|
i made the change which you suggested |
DaniElectra
requested changes
Aug 2, 2026
DaniElectra
left a comment
DaniElectra
left a comment
Member
There was a problem hiding this comment.
The logic looks good, only some formatting changes
Author
|
i made the requested changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6 and #3
Changes:
implemented
GetCompetitionRankingScoreimplemented
UploadCompetitionRankingScoreswitched stationurls arround so that the public one is first
I have read and agreed to the Code of Conduct.
I have read and complied with the contributing guidelines.
What I'm implementing was an approved issue.
I have tested all of my changes.