Implement UploadCompetitionRankingScore for Splatfest - #19
Conversation
Finally got around to finishing the Splatfest implementation. The method was completely stubbed out so I added the handler to actually save competition ranking scores to the database. Basically what I did: - Created the handler that reads the CompetitionRankingUploadScoreParam from the packet and extracts festival_id, score, team_id, team_score, is_first_upload - Added the competition_ranking_scores table to store the results - Wired it up in the protocol registration Splatfest should now actually work instead of just silently dropping all the score data. Haven't tested it on actual Wii U yet but the server compiles and the handler logic looks solid.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for uploading Splatoon competition ranking scores by wiring a new handler into the secure ranking protocol and persisting uploads to Postgres.
Changes:
- Registers
UploadCompetitionRankingScoreas the handler for the ranking protocol method. - Implements request parsing + DB insert for competition ranking score uploads.
- Adds a SQL schema for
competition_ranking_scores.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| nex/register_common_secure_server_protocols.go | Wires the new upload handler into the secure ranking protocol registration. |
| globals/upload_competition_ranking_score.go | Implements the upload handler: parses parameters and inserts into Postgres, returns RMC success. |
| competition_ranking_scores.sql | Introduces the competition_ranking_scores table used by the new handler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…or details in upload handler
|
Sorry I've been busy, will give a proper review soon. Just some questions:
|
Hey ashquarky! Thanks for responding, really appreciate that! |
Finally got around to finishing the Splatfest implementation. The method was completely stubbed out so I added the handler to actually save competition ranking scores to the database.
Basically what I did:
Splatfest should now actually work instead of just silently dropping all the score data. Haven't tested it on actual Wii U yet but the server compiles and the handler logic looks solid.
Resolves #6
Changes:
UploadCompetitionRankingScorehandler inglobals/upload_competition_ranking_score.gothat parses the NEX packet and extracts competition ranking datacompetition_ranking_scores.sqlwith schema for storing festival_id, score, team_id, team_score, is_first_uploadregister_common_secure_server_protocols.goDatabase migration: